Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 413573003: Allow QuicConnection to own its QuicPacketWriter (Closed)

Created:
6 years, 5 months ago by ramant (doing other things)
Modified:
6 years, 4 months ago
Reviewers:
wtc, Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org, wtc
Base URL:
https://chromium.googlesource.com/chromium/src.git@change_BBR_sender_71436337
Project:
chromium
Visibility:
Public.

Description

Allow QuicConnection to own its QuicPacketWriter Added a new "bool owns_writer" parameter to the QuicConnection constructor that specifies whether the QuicConnection has ownership. Also cleaned up the ownership semantics in a number of tests -- previously, the writer was not actually outliving the connection. Merge internal change: 71590341 R=rch@chromium.org

Patch Set 1 #

Patch Set 2 : minor cleanup #

Unified diffs Side-by-side diffs Delta from patch set Stats (+92 lines, -36 lines) Patch
M net/quic/quic_connection.h View 2 chunks +5 lines, -2 lines 0 comments Download
M net/quic/quic_connection.cc View 2 chunks +5 lines, -0 lines 0 comments Download
M net/quic/quic_connection_test.cc View 1 1 chunk +6 lines, -1 line 0 comments Download
M net/quic/quic_dispatcher.cc View 1 1 chunk +13 lines, -3 lines 0 comments Download
M net/quic/quic_http_stream_test.cc View 1 1 chunk +6 lines, -1 line 0 comments Download
M net/quic/quic_stream_factory.cc View 1 1 chunk +7 lines, -3 lines 0 comments Download
M net/quic/test_tools/quic_connection_peer.h View 1 chunk +4 lines, -1 line 0 comments Download
M net/quic/test_tools/quic_connection_peer.cc View 1 chunk +6 lines, -1 line 0 comments Download
M net/quic/test_tools/quic_test_utils.h View 1 chunk +0 lines, -1 line 0 comments Download
M net/quic/test_tools/quic_test_utils.cc View 1 4 chunks +4 lines, -4 lines 0 comments Download
M net/tools/quic/end_to_end_test.cc View 1 1 chunk +3 lines, -2 lines 0 comments Download
M net/tools/quic/quic_client.h View 2 chunks +4 lines, -3 lines 0 comments Download
M net/tools/quic/quic_client.cc View 1 1 chunk +12 lines, -5 lines 0 comments Download
M net/tools/quic/quic_dispatcher.cc View 1 1 chunk +13 lines, -4 lines 0 comments Download
M net/tools/quic/test_tools/quic_test_utils.h View 1 chunk +0 lines, -1 line 0 comments Download
M net/tools/quic/test_tools/quic_test_utils.cc View 1 4 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
ramant (doing other things)
6 years, 5 months ago (2014-07-22 23:57:07 UTC) #1
Ryan Hamilton
lgtm
6 years, 5 months ago (2014-07-23 03:38:08 UTC) #2
wtc
Daniel, should we merge this CL for you? I am worried that this may interfere ...
6 years, 5 months ago (2014-07-23 23:19:39 UTC) #3
dmz
On 2014/07/23 23:19:39, wtc wrote: > Daniel, should we merge this CL for you? I ...
6 years, 5 months ago (2014-07-23 23:21:09 UTC) #4
wtc
6 years, 5 months ago (2014-07-23 23:33:37 UTC) #5 
Patch set 2 LGTM.

Powered by Google App Engine
This is Rietveld 408576698