Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issue 413523006: Don't wipe data when provisioning non-rooted devices. (Closed)

Created:
6 years, 5 months ago by tonyg
Modified:
6 years, 5 months ago
Reviewers:
navabi1, jbudorick
CC:
chromium-reviews, klundberg+watch_chromium.org, yfriedman+watch_chromium.org, ilevy-cc_chromium.org
Project:
chromium
Visibility:
Public.

Description

Don't wipe data when provisioning non-rooted devices. If EnableAdbRoot fails, then we can't wipe the data because then we're not able to restore the adb_keys and the device never reappears. BUG=396120 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=285008

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -10 lines) Patch
M build/android/provision_devices.py View 2 chunks +19 lines, -10 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
tonyg
6 years, 5 months ago (2014-07-22 22:49:45 UTC) #1
navabi1
lgtm thanks Tony
6 years, 5 months ago (2014-07-23 12:35:31 UTC) #2
tonyg
The CQ bit was checked by tonyg@chromium.org
6 years, 5 months ago (2014-07-23 13:58:25 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tonyg@chromium.org/413523006/1
6 years, 5 months ago (2014-07-23 13:58:56 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_chromium_rel on tryserver.chromium ...
6 years, 5 months ago (2014-07-23 16:56:03 UTC) #5
commit-bot: I haz the power
6 years, 5 months ago (2014-07-23 19:11:08 UTC) #6
Message was sent while issue was closed.
Change committed as 285008

Powered by Google App Engine
This is Rietveld 408576698