Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(140)

Issue 413523003: [webcrypto] Properly fail-fast when importing RSA key as JWK with bad usages. (Closed)

Created:
6 years, 5 months ago by eroman
Modified:
6 years, 1 month ago
Reviewers:
Ryan Sleevi
CC:
chromium-reviews, darin-cc_chromium.org, jam
Project:
chromium
Visibility:
Public.

Description

[webcrypto] Properly fail-fast when importing RSA key as JWK with bad usages. BUG=395904 Committed: https://crrev.com/390613d63d41a91d55655887d25978772ca9c0a5 Cr-Commit-Position: refs/heads/master@{#301516}

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : rebase onto master #

Patch Set 4 : rebase onto master #

Patch Set 5 : Refactor: extract NSS/OpenSSL shared code to helper #

Patch Set 6 : revert patchset 5; won't generalize well for DH keys #

Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -5 lines) Patch
M content/child/webcrypto/nss/rsa_key_nss.cc View 1 2 3 5 1 chunk +10 lines, -2 lines 0 comments Download
M content/child/webcrypto/openssl/rsa_key_openssl.cc View 1 2 3 5 1 chunk +10 lines, -3 lines 0 comments Download
M content/child/webcrypto/test/rsa_ssa_unittest.cc View 1 2 3 1 chunk +26 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (1 generated)
eroman
6 years, 5 months ago (2014-07-22 18:51:05 UTC) #1
Ryan Sleevi
The spec (presently) doesn't require this. See https://www.w3.org/Bugs/Public/show_bug.cgi?id=26413 However, that's because the spec isn't clear ...
6 years, 5 months ago (2014-07-24 22:53:25 UTC) #2
eroman
Any update from the spec side?
6 years, 4 months ago (2014-08-04 15:29:13 UTC) #3
eroman
ping
6 years, 4 months ago (2014-08-19 21:50:16 UTC) #4
eroman
PTAL. The spec has clarified the behavior in: https://dvcs.w3.org/hg/webcrypto-api/rev/13846e3198f6 (In a separate CL I will ...
6 years, 2 months ago (2014-10-21 17:55:10 UTC) #5
Ryan Sleevi
lgtm
6 years, 1 month ago (2014-10-27 22:22:56 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/413523003/100001
6 years, 1 month ago (2014-10-27 23:01:45 UTC) #8
commit-bot: I haz the power
Committed patchset #6 (id:100001)
6 years, 1 month ago (2014-10-28 00:33:07 UTC) #9
commit-bot: I haz the power
6 years, 1 month ago (2014-10-28 00:33:50 UTC) #10
Message was sent while issue was closed.
Patchset 6 (id:??) landed as
https://crrev.com/390613d63d41a91d55655887d25978772ca9c0a5
Cr-Commit-Position: refs/heads/master@{#301516}

Powered by Google App Engine
This is Rietveld 408576698