Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(93)

Issue 413473003: Revert of Refactoring : Move AuthAttempt and Authenticators to chromeos/login (Closed)

Created:
6 years, 5 months ago by johnme
Modified:
6 years, 5 months ago
CC:
chromium-reviews, pam+watch_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, oshima+watch_chromium.org, nkostylev+watch_chromium.org
Project:
chromium
Visibility:
Public.

Description

Revert of Refactoring : Move AuthAttempt and Authenticators to chromeos/login (https://codereview.chromium.org/391373002/) Reason for revert: I'm afraid the BrowserThread layering violations in this patch actually cause compile failures on: http://build.chromium.org/p/chromium.webkit/builders/Linux%20ChromiumOS%20Tests%20%28dbg%29%281%29/builds/372 http://build.chromium.org/p/chromium.webkit/builders/Linux%20ChromiumOS%20Tests%20%28dbg%29%283%29/builds/364 Original issue's description: > Refactoring : Move AuthAttempt and Authenticators to chromeos/login > Extracted LoginEventRecorder from BootTimesLoader to loose dependecies. > > BUG=387613 > R=nkostylev@chromium.org > TBR=bauerb@chromium.org > TBR=stevenjb@chromium.org > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284682 TBR=bauerb@chromium.org,nkostylev@chromium.org,stevenjb@chromium.org,antrim@chromium.org NOTREECHECKS=true NOTRY=true BUG=387613 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284720

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1366 lines, -1470 lines) Patch
M chrome/browser/chromeos/boot_times_loader.h View 2 chunks +2 lines, -7 lines 0 comments Download
M chrome/browser/chromeos/chrome_browser_main_chromeos.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/login/app_launch_signin_screen.h View 1 chunk +1 line, -1 line 0 comments Download
A chrome/browser/chromeos/login/auth/auth_attempt_state.h View 1 chunk +117 lines, -0 lines 0 comments Download
A chrome/browser/chromeos/login/auth/auth_attempt_state.cc View 1 chunk +132 lines, -0 lines 0 comments Download
A chrome/browser/chromeos/login/auth/auth_attempt_state_resolver.h View 1 chunk +21 lines, -0 lines 0 comments Download
A chrome/browser/chromeos/login/auth/auth_attempt_state_resolver.cc View 1 chunk +13 lines, -0 lines 0 comments Download
A chrome/browser/chromeos/login/auth/authenticator.h View 1 chunk +110 lines, -0 lines 0 comments Download
A chrome/browser/chromeos/login/auth/authenticator.cc View 1 chunk +21 lines, -0 lines 0 comments Download
A chrome/browser/chromeos/login/auth/extended_authenticator.h View 1 chunk +161 lines, -0 lines 0 comments Download
A chrome/browser/chromeos/login/auth/extended_authenticator.cc View 1 chunk +383 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/login/auth/login_performer.h View 1 chunk +2 lines, -2 lines 0 comments Download
A chrome/browser/chromeos/login/auth/mock_auth_attempt_state_resolver.h View 1 chunk +26 lines, -0 lines 0 comments Download
A chrome/browser/chromeos/login/auth/mock_auth_attempt_state_resolver.cc View 1 chunk +13 lines, -0 lines 0 comments Download
A chrome/browser/chromeos/login/auth/mock_authenticator.h View 1 chunk +58 lines, -0 lines 0 comments Download
A chrome/browser/chromeos/login/auth/mock_authenticator.cc View 1 chunk +113 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/login/auth/online_attempt.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/login/auth/online_attempt_host.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/auth/online_attempt_host.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/auth/online_attempt_unittest.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/login/auth/parallel_authenticator.h View 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/browser/chromeos/login/auth/parallel_authenticator_unittest.cc View 2 chunks +1 line, -1 line 0 comments Download
A chrome/browser/chromeos/login/auth/test_attempt_state.h View 1 chunk +48 lines, -0 lines 0 comments Download
A chrome/browser/chromeos/login/auth/test_attempt_state.cc View 1 chunk +68 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/login/existing_user_controller_browsertest.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/login/fake_login_utils.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/lock/screen_locker.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/login/lock/screen_locker_browsertest.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/lock/screen_locker_tester.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/login_utils_browsertest.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/mock_login_utils.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/session/user_session_manager.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/supervised/supervised_user_creation_controller_new.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/supervised/supervised_user_login_flow.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/test_login_utils.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/test_login_utils.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/wizard_controller_browsertest.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/supervised_user/chromeos/manager_password_service.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/chrome_browser_chromeos.gypi View 2 chunks +10 lines, -0 lines 0 comments Download
M chrome/chrome_tests.gypi View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/chrome_tests_unit.gypi View 2 chunks +4 lines, -0 lines 0 comments Download
M chromeos/chromeos.gyp View 11 chunks +33 lines, -49 lines 0 comments Download
M chromeos/login/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
D chromeos/login/auth/auth_attempt_state.h View 1 chunk +0 lines, -118 lines 0 comments Download
D chromeos/login/auth/auth_attempt_state.cc View 1 chunk +0 lines, -133 lines 0 comments Download
D chromeos/login/auth/auth_attempt_state_resolver.h View 1 chunk +0 lines, -23 lines 0 comments Download
D chromeos/login/auth/auth_attempt_state_resolver.cc View 1 chunk +0 lines, -15 lines 0 comments Download
D chromeos/login/auth/authenticator.h View 1 chunk +0 lines, -110 lines 0 comments Download
D chromeos/login/auth/authenticator.cc View 1 chunk +0 lines, -22 lines 0 comments Download
D chromeos/login/auth/extended_authenticator.h View 1 chunk +0 lines, -162 lines 0 comments Download
D chromeos/login/auth/extended_authenticator.cc View 1 chunk +0 lines, -384 lines 0 comments Download
D chromeos/login/auth/mock_auth_attempt_state_resolver.h View 1 chunk +0 lines, -29 lines 0 comments Download
D chromeos/login/auth/mock_auth_attempt_state_resolver.cc View 1 chunk +0 lines, -15 lines 0 comments Download
D chromeos/login/auth/mock_authenticator.h View 1 chunk +0 lines, -57 lines 0 comments Download
D chromeos/login/auth/mock_authenticator.cc View 1 chunk +0 lines, -111 lines 0 comments Download
D chromeos/login/auth/test_attempt_state.h View 1 chunk +0 lines, -49 lines 0 comments Download
D chromeos/login/auth/test_attempt_state.cc View 1 chunk +0 lines, -69 lines 0 comments Download
D chromeos/login_event_recorder.h View 1 chunk +0 lines, -45 lines 0 comments Download
D chromeos/login_event_recorder.cc View 1 chunk +0 lines, -37 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
johnme
Created Revert of Refactoring : Move AuthAttempt and Authenticators to chromeos/login
6 years, 5 months ago (2014-07-22 17:19:18 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/johnme@chromium.org/413473003/1
6 years, 5 months ago (2014-07-22 17:20:18 UTC) #2
commit-bot: I haz the power
Change committed as 284720
6 years, 5 months ago (2014-07-22 17:22:41 UTC) #3
Bernhard Bauer
By compile failures you mean test failures? Those links are to bots that don't run ...
6 years, 5 months ago (2014-07-22 17:43:04 UTC) #4
johnme
On 2014/07/22 17:43:04, Bernhard Bauer wrote: > By compile failures you mean test failures? Those ...
6 years, 5 months ago (2014-07-22 17:44:49 UTC) #5
Bernhard Bauer
6 years, 5 months ago (2014-07-22 17:50:37 UTC) #6
Ah, that makes sense. I was wondering why those tests were failing without
error messages, and didn't see the symbol lookup error. Thanks for the
explanation!


On Tue, Jul 22, 2014 at 6:44 PM, <johnme@chromium.org> wrote:

> On 2014/07/22 17:43:04, Bernhard Bauer wrote:
>
>> By compile failures you mean test failures? Those links are to bots that
>> don't
>> run builds, they just run tests on downloaded builds.
>>
>
> Er, yes, I mean that symbol lookup errors occur at runtime.
>
> https://codereview.chromium.org/413473003/
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

Powered by Google App Engine
This is Rietveld 408576698