Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(492)

Issue 413453002: Canonicalize the authenticated username on iOS. (Closed)

Created:
6 years, 5 months ago by msarda
Modified:
6 years, 3 months ago
CC:
chromium-reviews
Project:
chromium
Visibility:
Public.

Description

Canonicalize the authenticated username on iOS. The account reconcilor uses the canonicalized emails to look up accounts in the ProfileOAuth2TokenService. This CL canonicalizes the authenticated username when the sign-in manager initializes for backward compability. TEST=Also regression test to check that nothing breaks for pre-SSO signed in users. BUG=394355 Committed: https://crrev.com/6458afea246f5f7dd2b7f4f3e3f55a7c109b6b75 Cr-Commit-Position: refs/heads/master@{#295055}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -1 line) Patch
M components/signin/core/browser/signin_manager_base.cc View 1 chunk +9 lines, -1 line 0 comments Download

Messages

Total messages: 6 (1 generated)
msarda
Please take a look.
6 years, 5 months ago (2014-07-22 13:26:36 UTC) #1
Roger Tawa OOO till Jul 10th
lgtm
6 years, 4 months ago (2014-07-28 14:11:01 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/413453002/1
6 years, 3 months ago (2014-09-16 12:48:11 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1) as 11878a9da2ebedb13ccf51a0dc6f85967e428fbd
6 years, 3 months ago (2014-09-16 13:47:05 UTC) #5
commit-bot: I haz the power
6 years, 3 months ago (2014-09-16 13:48:28 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6458afea246f5f7dd2b7f4f3e3f55a7c109b6b75
Cr-Commit-Position: refs/heads/master@{#295055}

Powered by Google App Engine
This is Rietveld 408576698