Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5881)

Unified Diff: chrome/browser/ui/views/passwords/manage_passwords_bubble_view.cc

Issue 413433002: Refactor BubbleDelegateView::use_focuseless() (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: nit + rebase Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/passwords/manage_passwords_bubble_view.cc
diff --git a/chrome/browser/ui/views/passwords/manage_passwords_bubble_view.cc b/chrome/browser/ui/views/passwords/manage_passwords_bubble_view.cc
index 8a4a2f256730db69edf4d79ef1f400a7f12b83af..46b9817a001ce9d3544727dfdef83c30b3f6dce8 100644
--- a/chrome/browser/ui/views/passwords/manage_passwords_bubble_view.cc
+++ b/chrome/browser/ui/views/passwords/manage_passwords_bubble_view.cc
@@ -538,13 +538,7 @@ void ManagePasswordsBubbleView::ShowBubble(content::WebContents* web_contents,
manage_passwords_bubble_->AdjustForFullscreen(
browser_view->GetBoundsInScreen());
}
- manage_passwords_bubble_->GetWidget()->Show();
- // set_use_focusless(true) has adverse effect on Windows.
- // 1) The bubble can't be the active window (which is not desired behavior).
- // 2) The bubble doesn't get WM_LBUTTONDOWN event. Therefore, all the buttons
- // get stuck.
- // TODO(vasilii): remove this line once the bug in infrastructure is resolved.
- manage_passwords_bubble_->set_use_focusless(false);
+ manage_passwords_bubble_->GetWidget()->ShowInactive();
}
// static
@@ -572,8 +566,6 @@ ManagePasswordsBubbleView::ManagePasswordsBubbleView(
never_save_passwords_(false) {
// Compensate for built-in vertical padding in the anchor view's image.
set_anchor_view_insets(gfx::Insets(5, 0, 5, 0));
- // Don't focus by default.
- set_use_focusless(true);
if (anchor_view)
anchor_view->SetActive(true);
}

Powered by Google App Engine
This is Rietveld 408576698