Issue 41343003: Remove dead code for reflected attributes on <audio>, <video> and <track>

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 41343003: Remove dead code for reflected attributes on <audio>, <video> and <track> (Closed)

Created:
7 years, 1 month ago by philipj_slow

Modified:
7 years, 1 month ago

Reviewers:
acolwell GONE FROM CHROMIUM, adamk

CC:
blink-reviews, nessy, philipj_slow, feature-media-reviews_chromium.org, dglazkov+blink, adamk+blink_chromium.org, vcarbune.chromium

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Visibility:
Public.

More Reviews

Description

Remove dead code for reflected attributes on <audio>, <video> and <track> Where [Reflect] is used in the IDL, the getters and setters in C++ are only for internal convenience, and these were unused. BUG=none Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=160637

Patch Set 1 #

Created: 7 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+0 lines, -37 lines)			Patch
M	Source/core/html/HTMLMediaElement.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	Source/core/html/HTMLMediaElement.cpp	View	1 chunk	+0 lines, -6 lines	0 comments	Download
M	Source/core/html/HTMLTrackElement.h	View	1 chunk	+0 lines, -3 lines	0 comments	Download
M	Source/core/html/HTMLTrackElement.cpp	View	1 chunk	+0 lines, -10 lines	0 comments	Download
M	Source/core/html/HTMLVideoElement.h	View	1 chunk	+0 lines, -3 lines	0 comments	Download
M	Source/core/html/HTMLVideoElement.cpp	View	1 chunk	+0 lines, -14 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/philipj@opera.com/41343003/1

7 years, 1 month ago (2013-10-25 22:06:23 UTC) #3

Message was sent while issue was closed.

Change committed as 160637

Expand Messages | Collapse Messages