Issue 413413003: DevTools: [Elements] Do not copy nodes if there is a non-collapsed selection

Issue 413413003: DevTools: [Elements] Do not copy nodes if there is a non-collapsed selection (Closed)

Created:
6 years, 4 months ago by apavlov

Modified:
6 years, 4 months ago

Reviewers:
aandrey, pfeldman

CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org

Base URL:
svn://svn.chromium.org/blink/trunk

Project:
blink

Visibility:
Public.

More Reviews

Description

DevTools: [Elements] Do not copy nodes if there is a non-collapsed selection This got regressed in r179031 R=aandrey, pfeldman NOTRY=true Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=179144

Patch Set 1 #

Total comments: 1

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -0 lines)			Patch
	M	Source/devtools/front_end/elements/ElementsPanel.js	View		1 chunk	+2 lines, -0 lines	1 comment	Download
	M	Source/devtools/front_end/elements/ElementsTreeOutline.js	View		1 chunk	+4 lines, -0 lines	0 comments	Download

Messages

Total messages: 9 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/apavlov@chromium.org/413413003/1

6 years, 4 months ago (2014-07-29 13:37:44 UTC) #6

aandrey

https://codereview.chromium.org/413413003/diff/1/Source/devtools/front_end/elements/ElementsPanel.js File Source/devtools/front_end/elements/ElementsPanel.js (right): https://codereview.chromium.org/413413003/diff/1/Source/devtools/front_end/elements/ElementsPanel.js#newcode1220 Source/devtools/front_end/elements/ElementsPanel.js:1220: if (!WebInspector.currentFocusElement().enclosingNodeOrSelfWithClass("elements-tree-outline")) WebInspector.currentFocusElement() can return undefined

6 years, 4 months ago (2014-07-29 13:38:25 UTC) #7

Message was sent while issue was closed.

Change committed as 179144

Expand Messages | Collapse Messages