Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(993)

Issue 413403011: Revert of Introduce NON_ZERO_DURATION for animation unit tests (Closed)

Created:
6 years, 4 months ago by James Cook
Modified:
6 years, 4 months ago
Reviewers:
ajuma, oshima, sky
CC:
chromium-reviews, sadrul, yusukes+watch_chromium.org, sievers+watch_chromium.org, yukishiino+watch_chromium.org, ben+aura_chromium.org, tdanderson+views_chromium.org, jam, jbauman+watch_chromium.org, nona+watch_chromium.org, darin-cc_chromium.org, timurrrr+watch_chromium.org, kalyank, bruening+watch_chromium.org, tdanderson+overview_chromium.org, penghuang+watch_chromium.org, piman+watch_chromium.org, ben+views_chromium.org, Ian Vollick, tfarina, danakj+watch_chromium.org, James Su, glider+watch_chromium.org, ben+ash_chromium.org
Project:
chromium
Visibility:
Public.

Description

Revert of Introduce NON_ZERO_DURATION for animation unit tests (https://codereview.chromium.org/420013002/) Reason for revert: I suspect this is causing Linux Tests dbg (2) failures in app_list_unittests: http://build.chromium.org/p/chromium.linux/builders/Linux%20Tests%20%28dbg%29%282%29/builds/47929 Strangely I had green try runs for linux_chromium_rel for app_list_unittests. Original issue's description: > Introduce NON_ZERO_DURATION for animation unit tests > > Animations are usually disabled in unit tests for performance. However, to > test the animation system itself some tests request "normal" durations. > Under some conditions (remote desktop, animation disabled for accessibility) > the "normal" duration could still be zero. > > This was causing test failures and use-after-frees in ash_unittests on the > drmemory bots and for developers using remote desktop. > > Introduce NON_ZERO_DURATION to signal that animation must be enabled and the > duration must be non-zero, but other than that can be as short as possible. > > BUG=397478, 396969 > TEST=ash_unittests on drmemory, Windows and Chrome OS bots > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=286089 TBR=oshima@chromium.org,ajuma@chromium.org,sky@chromium.org NOTREECHECKS=true NOTRY=true BUG=397478, 396969 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=286102

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+74 lines, -76 lines) Patch
M ash/desktop_background/desktop_background_controller_unittest.cc View 4 chunks +7 lines, -8 lines 0 comments Download
M ash/shelf/shelf_layout_manager_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M ash/wm/overview/window_selector_unittest.cc View 2 chunks +6 lines, -6 lines 0 comments Download
M ash/wm/window_animations_unittest.cc View 3 chunks +4 lines, -7 lines 0 comments Download
M ash/wm/workspace_controller_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/web_contents/aura/window_slider_unittest.cc View 1 chunk +1 line, -2 lines 0 comments Download
M tools/valgrind/drmemory/suppressions.txt View 1 chunk +18 lines, -0 lines 0 comments Download
M tools/valgrind/gtest_exclude/ash_unittests.gtest-drmemory_win32.txt View 1 chunk +6 lines, -0 lines 0 comments Download
M ui/aura/window_unittest.cc View 5 chunks +10 lines, -10 lines 0 comments Download
M ui/compositor/layer_animation_element.cc View 2 chunks +7 lines, -9 lines 0 comments Download
M ui/compositor/layer_animator_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ui/compositor/scoped_animation_duration_scale_mode.h View 1 chunk +0 lines, -4 lines 0 comments Download
M ui/keyboard/keyboard_controller_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ui/views/controls/textfield/textfield.cc View 1 chunk +0 lines, -1 line 0 comments Download
M ui/views/widget/widget_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/wm/core/visibility_controller_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ui/wm/core/window_animations.cc View 2 chunks +4 lines, -18 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
James Cook
Created Revert of Introduce NON_ZERO_DURATION for animation unit tests
6 years, 4 months ago (2014-07-29 05:02:48 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jamescook@chromium.org/413403011/1
6 years, 4 months ago (2014-07-29 05:04:25 UTC) #2
commit-bot: I haz the power
6 years, 4 months ago (2014-07-29 05:06:27 UTC) #3
Message was sent while issue was closed.
Change committed as 286102

Powered by Google App Engine
This is Rietveld 408576698