Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(364)

Issue 413403005: Pass clip blitter rows preserved request (Closed)

Created:
6 years, 4 months ago by krajcevski
Modified:
6 years, 4 months ago
Reviewers:
robertphillips, reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Pass clip blitter rows preserved request Committed: https://skia.googlesource.com/skia/+/fdd7d2b3dc8ce54922c3b170bbc2b3930bcb5d56

Patch Set 1 #

Total comments: 4

Patch Set 2 : SK_OVERRIDE #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -0 lines) Patch
M src/core/SkBlitter.h View 1 2 chunks +8 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
krajcevski
This fixes a bug where we're not fulfilling the assumptions in the compressed blitter when ...
6 years, 4 months ago (2014-07-28 21:30:50 UTC) #1
robertphillips
lgtm + nits https://codereview.chromium.org/413403005/diff/1/src/core/SkBlitter.h File src/core/SkBlitter.h (right): https://codereview.chromium.org/413403005/diff/1/src/core/SkBlitter.h#newcode153 src/core/SkBlitter.h:153: override ? https://codereview.chromium.org/413403005/diff/1/src/core/SkBlitter.h#newcode185 src/core/SkBlitter.h:185: override ?
6 years, 4 months ago (2014-07-29 12:37:53 UTC) #2
krajcevski
The CQ bit was checked by krajcevski@google.com
6 years, 4 months ago (2014-07-29 14:08:59 UTC) #3
krajcevski
https://codereview.chromium.org/413403005/diff/1/src/core/SkBlitter.h File src/core/SkBlitter.h (right): https://codereview.chromium.org/413403005/diff/1/src/core/SkBlitter.h#newcode153 src/core/SkBlitter.h:153: On 2014/07/29 12:37:53, robertphillips wrote: > override ? Done. ...
6 years, 4 months ago (2014-07-29 14:09:04 UTC) #4
krajcevski
The CQ bit was unchecked by krajcevski@google.com
6 years, 4 months ago (2014-07-29 14:09:07 UTC) #5
krajcevski
The CQ bit was checked by krajcevski@google.com
6 years, 4 months ago (2014-07-29 14:09:12 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/krajcevski@google.com/413403005/20001
6 years, 4 months ago (2014-07-29 14:09:37 UTC) #7
commit-bot: I haz the power
6 years, 4 months ago (2014-07-29 14:21:46 UTC) #8
Message was sent while issue was closed.
Change committed as fdd7d2b3dc8ce54922c3b170bbc2b3930bcb5d56

Powered by Google App Engine
This is Rietveld 408576698