Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(4)

Issue 413393006: Fix two uninitialized variables in media (Closed)

Created:
3 years, 3 months ago by Will Harris
Modified:
3 years, 3 months ago
CC:
chromium-reviews, feature-media-reviews_chromium.org
Project:
chromium
Visibility:
Public.

Description

Fix two uninitialized variables in media. BUG=397762 TEST=compile with no errors R=dalecurtis@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=285741

Patch Set 1 #

Total comments: 1

Patch Set 2 : re-arrange as pkasting suggestion #

Total comments: 6

Patch Set 3 : MSVS is crazy #

Total comments: 2

Patch Set 4 : style nits mostly back to ps2 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -9 lines) Patch
M media/filters/stream_parser_factory.cc View 1 2 3 1 chunk +7 lines, -8 lines 0 comments Download
M media/formats/mp4/box_definitions.cc View 1 chunk +1 line, -1 line 0 comments Download
Trybot results:

Messages

Total messages: 12 (0 generated)
Will Harris
not sure why this has just started happening, but here is a fix.
3 years, 3 months ago (2014-07-26 00:38:58 UTC) #1
Will Harris
On 2014/07/26 00:38:58, Will Harris wrote: > not sure why this has just started happening, ...
3 years, 3 months ago (2014-07-26 00:41:13 UTC) #2
Peter Kasting
https://codereview.chromium.org/413393006/diff/1/media/filters/stream_parser_factory.cc File media/filters/stream_parser_factory.cc (right): https://codereview.chromium.org/413393006/diff/1/media/filters/stream_parser_factory.cc#newcode113 media/filters/stream_parser_factory.cc:113: !base::HexStringToInt(tokens[2], &audio_object_type)) { Note: You _might_ be able to ...
3 years, 3 months ago (2014-07-26 00:45:34 UTC) #3
DaleCurtis
lgtm
3 years, 3 months ago (2014-07-26 00:52:40 UTC) #4
Will Harris
On 2014/07/26 00:52:40, DaleCurtis wrote: > lgtm I re-arranged as per-pkasting suggestion so now it ...
3 years, 3 months ago (2014-07-26 00:58:35 UTC) #5
Peter Kasting
https://codereview.chromium.org/413393006/diff/20001/media/filters/stream_parser_factory.cc File media/filters/stream_parser_factory.cc (right): https://codereview.chromium.org/413393006/diff/20001/media/filters/stream_parser_factory.cc#newcode111 media/filters/stream_parser_factory.cc:111: int audio_object_type; This works too, but I was suggesting ...
3 years, 3 months ago (2014-07-26 01:01:36 UTC) #6
DaleCurtis
https://codereview.chromium.org/413393006/diff/20001/media/filters/stream_parser_factory.cc File media/filters/stream_parser_factory.cc (right): https://codereview.chromium.org/413393006/diff/20001/media/filters/stream_parser_factory.cc#newcode110 media/filters/stream_parser_factory.cc:110: tokens[0] != "mp4a" || tokens[1] == "40") { == ...
3 years, 3 months ago (2014-07-26 01:06:38 UTC) #7
Will Harris
PTAL https://codereview.chromium.org/413393006/diff/20001/media/filters/stream_parser_factory.cc File media/filters/stream_parser_factory.cc (right): https://codereview.chromium.org/413393006/diff/20001/media/filters/stream_parser_factory.cc#newcode110 media/filters/stream_parser_factory.cc:110: tokens[0] != "mp4a" || tokens[1] == "40") { ...
3 years, 3 months ago (2014-07-26 01:15:54 UTC) #8
Peter Kasting
https://codereview.chromium.org/413393006/diff/40001/media/filters/stream_parser_factory.cc File media/filters/stream_parser_factory.cc (right): https://codereview.chromium.org/413393006/diff/40001/media/filters/stream_parser_factory.cc#newcode112 media/filters/stream_parser_factory.cc:112: if (base::HexStringToInt(tokens[2], &audio_object_type)) Well, if you're still going to ...
3 years, 3 months ago (2014-07-26 01:17:49 UTC) #9
Will Harris
This must be almost a record for the most patchsets per lines changed. https://codereview.chromium.org/413393006/diff/40001/media/filters/stream_parser_factory.cc File ...
3 years, 3 months ago (2014-07-26 01:25:06 UTC) #10
Peter Kasting
Cool. Can you go ahead and check in manually right away? The official Win builder ...
3 years, 3 months ago (2014-07-26 01:31:32 UTC) #11
Will Harris
3 years, 3 months ago (2014-07-26 01:33:39 UTC) #12
Message was sent while issue was closed.
Committed patchset #4 manually as r285741 (tree was closed).

Powered by Google App Engine
This is Rietveld efc10ee0f