Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(501)

Unified Diff: net/quic/crypto/quic_crypto_client_config.cc

Issue 413363005: QUIC - track CHLO's reject reason for secure QUIC vs insecure QUIC. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@Final_0723
Patch Set: Fixed comments Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/quic/crypto/quic_crypto_client_config.cc
diff --git a/net/quic/crypto/quic_crypto_client_config.cc b/net/quic/crypto/quic_crypto_client_config.cc
index 33d5242b708bf82bfc6bd79b5109b520cee3b56d..a75eef3f7a085ad9523814547abbffc86aed71b3 100644
--- a/net/quic/crypto/quic_crypto_client_config.cc
+++ b/net/quic/crypto/quic_crypto_client_config.cc
@@ -585,6 +585,7 @@ QuicErrorCode QuicCryptoClientConfig::ProcessRejection(
const CryptoHandshakeMessage& rej,
QuicWallTime now,
CachedState* cached,
+ bool is_https,
QuicCryptoNegotiatedParameters* out_params,
string* error_details) {
DCHECK(error_details != NULL);
@@ -621,8 +622,13 @@ QuicErrorCode QuicCryptoClientConfig::ProcessRejection(
packed_error |= 1 << (reason - 1);
}
DVLOG(1) << "Reasons for rejection: " << packed_error;
- UMA_HISTOGRAM_SPARSE_SLOWLY("Net.QuicClientHelloRejectReasons",
- packed_error);
+ if (is_https) {
+ UMA_HISTOGRAM_SPARSE_SLOWLY("Net.QuicClientHelloRejectReasons.Secure",
+ packed_error);
+ } else {
+ UMA_HISTOGRAM_SPARSE_SLOWLY("Net.QuicClientHelloRejectReasons.InSecure",
+ packed_error);
+ }
}
return QUIC_NO_ERROR;

Powered by Google App Engine
This is Rietveld 408576698