QUIC - track CHLO's reject reason for secure QUIC vs insecure QUIC.

tools/metrics/histograms/histograms.xml

Index: tools/metrics/histograms/histograms.xml
diff --git a/tools/metrics/histograms/histograms.xml b/tools/metrics/histograms/histograms.xml
index 857d27189ce35b7be1f80f9f69ceb887f199bf62..6b30e7d39abeddfa653569bede282d0580bb3efa 100644
--- a/tools/metrics/histograms/histograms.xml
+++ b/tools/metrics/histograms/histograms.xml
@@ -14905,12 +14905,34 @@ Therefore, the affected-histogram name has to have at least one dot in it.
 </histogram>
 
 <histogram name="Net.QuicClientHelloRejectReasons" enum="QuicRejectReasons">
+  <obsolete>
+    Deprecated as of 08/2014, replaced by
+    Net.QuicClientHelloRejectReasons*Secure.
+  </obsolete>
   <owner>rtenneti@chromium.org</owner>
   <summary>
     The reject reasons for QUIC's CHLO (client hello) message from server.
   </summary>
 </histogram>
 
+<histogram name="Net.QuicClientHelloRejectReasonsInSecure"

[Alexei Svitkine (slow), 2014/07/28 17:46:50]

Nit: Suggest naming these:

Net.QuicClientHelloRejectReasons.InSecure

and

Net.QuicClientHelloRejectReasons.Secure

Then, you can actually keep the existing histogram definition about and simply
add a histogram_suffixes tag over it (see examples in this file) with suffixes
InSecure and Secure (and separator=".").

[ramant (doing other things), 2014/07/28 18:43:33]

Thanks for the above suggestion.

Done.

+    enum="QuicRejectReasons">
+  <owner>rtenneti@chromium.org</owner>
+  <summary>
+    The reject reasons for QUIC's CHLO (client hello) message from server for
+    inscure QUIC.

[Alexei Svitkine (slow), 2014/07/28 17:46:50]

Nit: insecure (typo)

[ramant (doing other things), 2014/07/28 18:43:33]

Done.

+  </summary>
+</histogram>
+
+<histogram name="Net.QuicClientHelloRejectReasonsSecure"
+    enum="QuicRejectReasons">
+  <owner>rtenneti@chromium.org</owner>
+  <summary>
+    The reject reasons for QUIC's CHLO (client hello) message from server for
+    secure QUIC.
+  </summary>
+</histogram>
+
 <histogram name="Net.QuicEphemeralPortsSuggested">
   <owner>rch@chromium.org</owner>
   <summary>The number of ports suggested per server.</summary>