tools/metrics/histograms/histograms.xml

Index: tools/metrics/histograms/histograms.xml
diff --git a/tools/metrics/histograms/histograms.xml b/tools/metrics/histograms/histograms.xml
index 316fca0710846a55b33f734779e133b9d8726142..dc35c43497edbbb2b2e0a2fcb8080d55962fa00f 100644
--- a/tools/metrics/histograms/histograms.xml
+++ b/tools/metrics/histograms/histograms.xml
@@ -14915,7 +14915,7 @@ Therefore, the affected-histogram name has to have at least one dot in it.
 <histogram name="Net.QuicClientHelloRejectReasons" enum="QuicRejectReasons">
   <owner>rtenneti@chromium.org</owner>
   <summary>
-    The reject reasons for QUIC's CHLO (client hello) message from server.
+    The reject reasons for QUIC's CHLO (client hello) message from server

[wtc, 2014/07/29 01:37:10]

Did you delete the period accidentally?

If the label for the suffix will be appended, should the label begin with a
space?

[ramant (doing other things), 2014/07/29 03:55:37]

My understanding is, it adds a space when it concatenates histogram_suffixes

   </summary>
 </histogram>
 
@@ -51080,6 +51080,13 @@ Therefore, the affected-histogram name has to have at least one dot in it.
   <affected-histogram name="Net.ProxyResolver.ExecutionTime"/>
 </histogram_suffixes>
 
+<histogram_suffixes name="NetQuicClientHelloRejectReasons" separator=".">

[wtc, 2014/07/29 01:37:10]

Nit: "NetQuicClientHelloRejectReasons" seems like a poor name for the suffix. It
seems that the suffix name should mention whether QUIC is secure or not.

[ramant (doing other things), 2014/07/29 03:55:36]

Updated the name.

(sorry if already known)
name="NetQuicClientHelloRejectReasons" is not used in the code (my understanding
is, it is more to differentiate histogram_suffixes).

Histogram names are
  Net.QuicClientHelloRejectReasons.Secure
  Net.QuicClientHelloRejectReasons.Insecure

+  <owner>rtenneti@chromium.org</owner>
+  <suffix name="Insecure" label="for insecure QUIC."/>
+  <suffix name="Secure" label="for secure QUIC."/>
+  <affected-histogram name="Net.QuicClientHelloRejectReasons"/>
+</histogram_suffixes>
+
 <histogram_suffixes name="NewTabPageProviders" separator=".">
   <suffix name="client" label="Suggestions coming from the client."/>
   <suffix name="client0" label="Suggestions coming from the client source 0."/>