Issue 413363004: Use tighter typing in editing/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 413363004: Use tighter typing in editing/ (Closed)

Created:
6 years, 5 months ago by Inactive

Modified:
6 years, 5 months ago

Reviewers:
leviw_travelin_and_unemployed

CC:
blink-reviews

Base URL:
svn://svn.chromium.org/blink/trunk

Project:
blink

Visibility:
Public.

Use tighter typing in editing/ Use tighter typing in editing/ to increase code readability. This CL focuses on ApplyBlockElementCommand. R=leviw@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=178950

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+12 lines, -12 lines)			Patch
M	Source/core/editing/ApplyBlockElementCommand.h	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	Source/core/editing/ApplyBlockElementCommand.cpp	View	3 chunks	+4 lines, -4 lines	0 comments	Download
M	Source/core/editing/FormatBlockCommand.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/editing/FormatBlockCommand.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/editing/IndentOutdentCommand.h	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	Source/core/editing/IndentOutdentCommand.cpp	View	2 chunks	+2 lines, -2 lines	0 comments	Download

Total messages: 5 (0 generated)

leviw_travelin_and_unemployed

The CQ bit was checked by leviw@chromium.org

6 years, 5 months ago (2014-07-25 19:28:40 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/413363004/1

6 years, 5 months ago (2014-07-25 19:29:24 UTC) #4

Message was sent while issue was closed.

Change committed as 178950