Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(233)

Issue 413363003: Use a default string when calling os.getenv in bisect-perf-regression.py. (Closed)

Created:
6 years, 5 months ago by qyearsley
Modified:
6 years, 5 months ago
Reviewers:
prasadv
CC:
chromium-reviews
Project:
chromium
Visibility:
Public.

Description

Use a default string when calling os.getenv in bisect-perf-regression.py. BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=285679

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M tools/bisect-perf-regression.py View 3 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
qyearsley
The test bisect-perf-regression_test.py was failing because the GYP_DEFINES environment variable isn't (necessarily) set when the ...
6 years, 5 months ago (2014-07-25 00:09:33 UTC) #1
prasadv
lgtm
6 years, 5 months ago (2014-07-25 16:55:25 UTC) #2
qyearsley
The CQ bit was checked by qyearsley@chromium.org
6 years, 5 months ago (2014-07-25 19:47:51 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/qyearsley@chromium.org/413363003/1
6 years, 5 months ago (2014-07-25 19:49:15 UTC) #4
commit-bot: I haz the power
6 years, 5 months ago (2014-07-25 21:05:17 UTC) #5
Message was sent while issue was closed.
Change committed as 285679

Powered by Google App Engine
This is Rietveld 408576698