Move the app_shell_browsertests DNS apitest to chrome/browser/api/dns.

Move the app_shell_browsertests DNS apitest to chrome/browser/api/dns.

BUG=388893
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=285775

[James Cook, 2014-07-25 02:52:35]

LGTM

https://chromiumcodereview.appspot.com/413353003/diff/1/extensions/shell/app_...
File extensions/shell/app_shell.gyp (right):

https://chromiumcodereview.appspot.com/413353003/diff/1/extensions/shell/app_...
extensions/shell/app_shell.gyp:214: #     in the parent directory?
nit: Maybe don't indent this line? It looks funny.

Not for this CL: I think this is a sign that these should be
"extensions_browsertests" and live in the parent directory. Maybe. How does
src/content handle the distinction between content_shell and
content_browsertests?

[Yoyo Zhou, 2014-07-25 02:57:01]

https://chromiumcodereview.appspot.com/413353003/diff/1/extensions/shell/app_...
File extensions/shell/app_shell.gyp (right):

https://chromiumcodereview.appspot.com/413353003/diff/1/extensions/shell/app_...
extensions/shell/app_shell.gyp:214: #     in the parent directory?
On 2014/07/25 02:52:35, James Cook wrote:
> nit: Maybe don't indent this line? It looks funny.
> 
> Not for this CL: I think this is a sign that these should be
> "extensions_browsertests" and live in the parent directory.

I agree. app_shell_browsertests made more sense when this was a test for testing
app_shell. Now that app_shell is under the dominion of extensions, and tests are
running with ExtensionsShell, it's more sensible to not have app_shell in the
name. What to call app_shell_lib, though?

[James Cook, 2014-07-25 15:44:22]

https://chromiumcodereview.appspot.com/413353003/diff/1/extensions/shell/app_...
File extensions/shell/app_shell.gyp (right):

https://chromiumcodereview.appspot.com/413353003/diff/1/extensions/shell/app_...
extensions/shell/app_shell.gyp:214: #     in the parent directory?
On 2014/07/25 02:57:01, Yoyo Zhou wrote:
> On 2014/07/25 02:52:35, James Cook wrote:
> > nit: Maybe don't indent this line? It looks funny.
> > 
> > Not for this CL: I think this is a sign that these should be
> > "extensions_browsertests" and live in the parent directory.
> 
> I agree. app_shell_browsertests made more sense when this was a test for
testing
> app_shell. Now that app_shell is under the dominion of extensions, and tests
are
> running with ExtensionsShell, it's more sensible to not have app_shell in the
> name. What to call app_shell_lib, though?

Not sure. What does content do?

[Yoyo Zhou, 2014-07-25 20:43:38]

fixed the TODO.

https://chromiumcodereview.appspot.com/413353003/diff/1/extensions/shell/app_...
File extensions/shell/app_shell.gyp (right):

https://chromiumcodereview.appspot.com/413353003/diff/1/extensions/shell/app_...
extensions/shell/app_shell.gyp:214: #     in the parent directory?
On 2014/07/25 15:44:22, James Cook wrote:
> On 2014/07/25 02:57:01, Yoyo Zhou wrote:
> > On 2014/07/25 02:52:35, James Cook wrote:
> > > nit: Maybe don't indent this line? It looks funny.
> > > 
> > > Not for this CL: I think this is a sign that these should be
> > > "extensions_browsertests" and live in the parent directory.
> > 
> > I agree. app_shell_browsertests made more sense when this was a test for
> testing
> > app_shell. Now that app_shell is under the dominion of extensions, and tests
> are
> > running with ExtensionsShell, it's more sensible to not have app_shell in
the
> > name. What to call app_shell_lib, though?
> 
> Not sure. What does content do?

content_shell -> content_shell_lib
content_browsertests -> content_shell_lib

"extensions_shell_lib" is a possibility. Strange because there isn't an
extensions shell. "app_shell_lib" is not too bad if we leave it alone though.

[Yoyo Zhou, 2014-07-25 20:43:43]

The CQ bit was checked by yoz@chromium.org

[commit-bot: I haz the power, 2014-07-25 20:45:16]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/yoz@chromium.org/413353003/20001

[commit-bot: I haz the power, 2014-07-26 18:03:28]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  linux_chromium_rel_swarming on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[commit-bot: I haz the power, 2014-07-26 18:26:30]

Change committed as 285775