Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(402)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 413353002: Remove extraneous namespaces (Closed)

Created:
6 years, 5 months ago by DaveMoore
Modified:
6 years, 5 months ago
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Project:
chromium
Visibility:
Public.

Description

Remove extraneous namespaces BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=285771

Patch Set 1 #

Total comments: 3

Patch Set 2 : Review nits and merge #

Unified diffs Side-by-side diffs Delta from patch set Stats (+304 lines, -348 lines) Patch
M mojo/examples/browser/browser.cc View 1 2 chunks +3 lines, -4 lines 0 comments Download
M mojo/examples/embedded_app/embedded_app.cc View 1 4 chunks +17 lines, -17 lines 0 comments Download
M mojo/examples/media_viewer/media_viewer.cc View 1 5 chunks +11 lines, -11 lines 0 comments Download
M mojo/examples/nesting_app/nesting_app.cc View 1 3 chunks +17 lines, -18 lines 0 comments Download
M mojo/examples/png_viewer/png_viewer.cc View 1 2 chunks +5 lines, -5 lines 0 comments Download
M mojo/examples/surfaces_app/child.mojom View 1 chunk +2 lines, -2 lines 0 comments Download
M mojo/examples/surfaces_app/child_impl.h View 2 chunks +7 lines, -7 lines 0 comments Download
M mojo/examples/surfaces_app/child_impl.cc View 3 chunks +8 lines, -8 lines 0 comments Download
M mojo/examples/surfaces_app/embedder.h View 2 chunks +2 lines, -2 lines 0 comments Download
M mojo/examples/surfaces_app/embedder.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M mojo/examples/surfaces_app/surfaces_app.cc View 6 chunks +9 lines, -9 lines 0 comments Download
M mojo/examples/window_manager/debug_panel.h View 1 2 chunks +3 lines, -3 lines 0 comments Download
M mojo/examples/window_manager/debug_panel.cc View 1 2 chunks +6 lines, -8 lines 0 comments Download
M mojo/examples/window_manager/window_manager.cc View 1 13 chunks +36 lines, -37 lines 0 comments Download
M mojo/services/html_viewer/html_document_view.h View 1 1 chunk +1 line, -1 line 0 comments Download
M mojo/services/html_viewer/html_document_view.cc View 1 2 chunks +5 lines, -6 lines 0 comments Download
M mojo/services/html_viewer/html_viewer.cc View 1 2 chunks +6 lines, -6 lines 0 comments Download
M mojo/services/launcher/launcher.cc View 4 chunks +4 lines, -9 lines 0 comments Download
M mojo/services/public/cpp/surfaces/lib/surfaces_type_converters.cc View 21 chunks +78 lines, -85 lines 0 comments Download
M mojo/services/public/cpp/surfaces/surfaces_type_converters.h View 1 chunk +33 lines, -38 lines 0 comments Download
M mojo/services/public/cpp/surfaces/tests/surface_unittest.cc View 15 chunks +36 lines, -46 lines 0 comments Download
M mojo/services/public/interfaces/launcher/launcher.mojom View 2 chunks +2 lines, -2 lines 0 comments Download
M mojo/services/public/interfaces/navigation/navigation.mojom View 1 chunk +1 line, -1 line 0 comments Download
M mojo/services/public/interfaces/surfaces/quads.mojom View 2 chunks +2 lines, -2 lines 0 comments Download
M mojo/services/public/interfaces/surfaces/surface_id.mojom View 1 chunk +1 line, -1 line 0 comments Download
M mojo/services/public/interfaces/surfaces/surfaces.mojom View 3 chunks +5 lines, -5 lines 0 comments Download
M mojo/services/surfaces/surfaces_impl.h View 2 chunks +0 lines, -3 lines 0 comments Download
M mojo/services/surfaces/surfaces_impl.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M mojo/services/surfaces/surfaces_service_application.h View 2 chunks +0 lines, -3 lines 0 comments Download
M mojo/services/surfaces/surfaces_service_application.cc View 2 chunks +1 line, -4 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
DaveMoore
6 years, 5 months ago (2014-07-24 22:27:30 UTC) #1
darin (slow to review)
LGTM!! https://codereview.chromium.org/413353002/diff/1/mojo/examples/embedded_app/embedded_app.cc File mojo/examples/embedded_app/embedded_app.cc (right): https://codereview.chromium.org/413353002/diff/1/mojo/examples/embedded_app/embedded_app.cc#newcode38 mojo/examples/embedded_app/embedded_app.cc:38: class Navigator : public InterfaceImpl<mojo::Navigator> { nit: this ...
6 years, 5 months ago (2014-07-25 03:37:29 UTC) #2
DaveMoore
Review nits and merge
6 years, 5 months ago (2014-07-25 17:44:19 UTC) #3
DaveMoore
The CQ bit was checked by davemoore@chromium.org
6 years, 5 months ago (2014-07-25 17:44:29 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/davemoore@chromium.org/413353002/20001
6 years, 5 months ago (2014-07-25 17:45:32 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_chromium_rel on tryserver.chromium ...
6 years, 5 months ago (2014-07-26 05:02:30 UTC) #6
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_chromium_gn_rel on tryserver.chromium.linux ...
6 years, 5 months ago (2014-07-26 17:09:47 UTC) #7
commit-bot: I haz the power
6 years, 5 months ago (2014-07-26 18:24:09 UTC) #8
Message was sent while issue was closed. 
Change committed as 285771

Powered by Google App Engine
This is Rietveld 408576698