Issue 413303003: Remove const from int return type on aura::Env::mouse_button_flags()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 413303003: Remove const from int return type on aura::Env::mouse_button_flags() (Closed)

Created:
6 years, 5 months ago by msw

Modified:
6 years, 5 months ago

Reviewers:
sadrul, hshi1

CC:
chromium-reviews, ben+aura_chromium.org, kalyank, Andre, tapted, Daniel Erat

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Project:
chromium

Visibility:
Public.

Remove const from int return type on aura::Env::mouse_button_flags() I hit this building views_examples_exe on Mac with TOOLKIT_VIEWS=1. error: 'const' type qualifier on return type has no effect [-Werror,-Wignored-qualifiers] Added in r264669. BUG=NONE TEST=NONE TBR=sadrul@chromium.org,hshi@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=285461

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	ui/aura/env.h	View		1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 4 (0 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/msw@chromium.org/413303003/1

6 years, 5 months ago (2014-07-24 22:38:51 UTC) #3

Message was sent while issue was closed.

Change committed as 285461