Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(439)

Issue 413263002: Revert 283610 "Revert 283562 "Mojo: Enable mojo_shell_tests on W..." (Closed)

Created:
6 years, 5 months ago by viettrungluu
Modified:
6 years, 5 months ago
Reviewers:
sky, viettrungluu
CC:
chromium-reviews
Project:
chromium
Visibility:
Public.

Description

Revert 283610 "Revert 283562 "Mojo: Enable mojo_shell_tests on W..." Should be okay now, according to my local testing (see crbug.com/389666, etc.; crrev.com/285139 also fixed a use-after-free that would be picked up by this test on Debug builds). > Revert 283562 "Mojo: Enable mojo_shell_tests on Windows (on the ..." > > Blech: Stuff fails. Shockingly. > http://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%28dbg%29%284%29/builds/27268/steps/mojo_shell_tests/logs/stdio > > > Mojo: Enable mojo_shell_tests on Windows (on the bots). > > > > R=sky@chromium.org > > > > Review URL: https://codereview.chromium.org/398023002 > > TBR=viettrungluu@chromium.org > > Review URL: https://codereview.chromium.org/398253002 TBR=viettrungluu@chromium.org, sky@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=285430

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M testing/buildbot/chromium.win.json View 4 chunks +4 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
viettrungluu
The CQ bit was checked by viettrungluu@chromium.org
6 years, 5 months ago (2014-07-24 19:50:48 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/viettrungluu@chromium.org/413263002/1
6 years, 5 months ago (2014-07-24 19:54:07 UTC) #2
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_chromium_chromeos_rel on tryserver.chromium ...
6 years, 5 months ago (2014-07-24 23:08:48 UTC) #3
commit-bot: I haz the power
6 years, 5 months ago (2014-07-25 00:20:29 UTC) #4
Message was sent while issue was closed.
Change committed as 285430

Powered by Google App Engine
This is Rietveld 408576698