Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2595)

Unified Diff: cc/resources/tile_manager_perftest.cc

Issue 413243004: cc: Fix DCHECK in tile manager queue perftests. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: cc/resources/tile_manager_perftest.cc
diff --git a/cc/resources/tile_manager_perftest.cc b/cc/resources/tile_manager_perftest.cc
index 69bdaa468056cf1d1cefd28d9b5af8a0edd27b8b..7892f0fecdf1b70e8e7c9c841cb047a1e4498c52 100644
--- a/cc/resources/tile_manager_perftest.cc
+++ b/cc/resources/tile_manager_perftest.cc
@@ -351,26 +351,26 @@ TEST_F(TileManagerPerfTest, ManageTiles) {
}
TEST_F(TileManagerPerfTest, RasterTileQueueConstruct) {
- SetupDefaultTrees(gfx::Size(10000, 10000));
+ SetupDefaultTrees(gfx::Size(1000, 1000));
reveman 2014/07/24 19:52:58 What's the motivation for using this specific size
vmpstr 2014/07/24 19:58:21 The problem is really just creating all the tiles
reveman 2014/07/24 20:14:37 Acknowledged.
active_root_layer_->CreateDefaultTilingsAndTiles();
pending_root_layer_->CreateDefaultTilingsAndTiles();
RunRasterQueueConstructTest("2");
for (int i = 0; i < 8; ++i) {
- PictureLayerTiling* tiling = active_root_layer_->AddTiling(i * 0.3f);
+ PictureLayerTiling* tiling = active_root_layer_->AddTiling(1.3f + i * 0.3f);
tiling->CreateAllTilesForTesting();
}
RunRasterQueueConstructTest("10");
- for (int i = 0; i < 90; ++i) {
+ for (int i = 0; i < 40; ++i) {
PictureLayerTiling* tiling =
- active_root_layer_->AddTiling(1.0f + i * 0.03f);
+ active_root_layer_->AddTiling(2.03f + i * 0.03f);
tiling->CreateAllTilesForTesting();
}
- RunRasterQueueConstructTest("100");
+ RunRasterQueueConstructTest("50");
reveman 2014/07/24 19:52:58 why not 100? is the overlap in scales between the
vmpstr 2014/07/24 19:58:21 I don't think there's overlap? I mean the fix was
reveman 2014/07/24 20:14:37 I meant overlap in the sense that: 1.3f + i * 0.3
vmpstr 2014/07/24 21:37:36 Ah I see what you mean. That is better, I've chang
}
TEST_F(TileManagerPerfTest, RasterTileQueueConstructAndIterate) {
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698