Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(116)

Issue 413233002: Add a trace event to MemoryPressureListener::NotifyMemoryPressure. (Closed)

Created:
6 years, 5 months ago by rmcilroy
Modified:
6 years, 5 months ago
Reviewers:
Mark Mentovai
CC:
chromium-reviews, erikwright+watch_chromium.org, gavinp+memory_chromium.org, jochen (gone - plz use gerrit)
Project:
chromium
Visibility:
Public.

Description

Add a trace event to MemoryPressureListener::NotifyMemoryPressure. Add a trace event to MemoryPressureListener::NotifyMemoryPressure to enable tracking of whether any jank is caused by dealing with memory pressure notifications. BUG=397026 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=285449

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M base/memory/memory_pressure_listener.cc View 2 chunks +3 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
rmcilroy
Mark, could you please take a look, thanks.
6 years, 5 months ago (2014-07-24 17:59:07 UTC) #1
Mark Mentovai
LGTM
6 years, 5 months ago (2014-07-24 18:00:47 UTC) #2
rmcilroy
The CQ bit was checked by rmcilroy@chromium.org
6 years, 5 months ago (2014-07-24 18:08:40 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rmcilroy@chromium.org/413233002/1
6 years, 5 months ago (2014-07-24 18:11:44 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_chromium_chromeos_rel on tryserver.chromium ...
6 years, 5 months ago (2014-07-24 21:48:19 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-24 22:23:01 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_swarming on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_rel_swarming/builds/2118)
6 years, 5 months ago (2014-07-24 22:23:02 UTC) #7
rmcilroy
The CQ bit was checked by rmcilroy@chromium.org
6 years, 5 months ago (2014-07-24 22:27:40 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rmcilroy@chromium.org/413233002/1
6 years, 5 months ago (2014-07-24 22:29:29 UTC) #9
commit-bot: I haz the power
6 years, 5 months ago (2014-07-25 01:42:01 UTC) #10
Message was sent while issue was closed.
Change committed as 285449

Powered by Google App Engine
This is Rietveld 408576698