Revert r22597 (which should have been called: "Tests that the GC doesn't mistake non-pointer consta…

test/cctest/test-constantpool.cc

 // Copyright 2013 the V8 project authors. All rights reserved.
 
 // Test constant pool array code.
 
 #include "src/v8.h"
 
 #include "src/factory.h"
 #include "src/objects.h"
 #include "test/cctest/cctest.h"
 
@@ skipping 224 matching lines @@
 
   int expected_int64_indexs[] = { 0, 5, 6, 7, 8, 9 };
   CheckIterator(array, ConstantPoolArray::INT64, expected_int64_indexs, 6);
   int expected_code_indexs[1];
   CheckIterator(array, ConstantPoolArray::CODE_PTR, expected_code_indexs, 0);
   int expected_heap_indexs[] = { 10, 11, 12 };
   CheckIterator(array, ConstantPoolArray::HEAP_PTR, expected_heap_indexs, 3);
   int expected_int32_indexs[] = { 1, 2, 3, 4 };
   CheckIterator(array, ConstantPoolArray::INT32, expected_int32_indexs, 4);
 }
-
-
-TEST(ConstantPoolPreciseGC) {
-  LocalContext context;
-  Isolate* isolate = CcTest::i_isolate();
-  Heap* heap = isolate->heap();
-  Factory* factory = isolate->factory();
-  v8::HandleScope scope(context->GetIsolate());
-
-  ConstantPoolArray::NumberOfEntries small(1, 0, 0, 1);
-  Handle<ConstantPoolArray> array = factory->NewConstantPoolArray(small);
-
-  // Check that the store buffer knows which entries are pointers and which are
-  // not.  To do this, make non-pointer entries which look like new space
-  // pointers but are actually invalid and ensure the GC doesn't try to move
-  // them.
-  Handle<HeapObject> object = factory->NewHeapNumber(4.0);
-  Object* raw_ptr = *object;
-  // If interpreted as a pointer, this should be right inside the heap number
-  // which will cause a crash when trying to lookup the 'map' pointer.
-  int32_t invalid_ptr_int32 = reinterpret_cast<int32_t>(raw_ptr) + kInt32Size;
-  int64_t invalid_ptr_int64 = reinterpret_cast<int64_t>(raw_ptr) + kInt32Size;
-  array->set(0, invalid_ptr_int64);
-  array->set(1, invalid_ptr_int32);
-
-  // Ensure we perform a scan on scavenge for the constant pool's page.
-  MemoryChunk::FromAddress(array->address())->set_scan_on_scavenge(true);
-  heap->CollectGarbage(NEW_SPACE);
-
-  // Check the object was moved by GC.
-  CHECK_NE(*object, raw_ptr);
-
-  // Check the non-pointer entries weren't changed.
-  CHECK_EQ(invalid_ptr_int64, array->get_int64_entry(0));
-  CHECK_EQ(invalid_ptr_int32, array->get_int32_entry(1));
-}