Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issue 413173002: Revert r22597 (which should have been called: "Tests that the GC doesn't mistake non-pointer consta… (Closed)

Created:
6 years, 5 months ago by rmcilroy
Modified:
6 years, 5 months ago
Reviewers:
Yang
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

Revert r22597 (which should have been called: "Tests that the GC doesn't mistake non-pointer constant pool entries as poitners.") TBR=yangguo@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=22598

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -38 lines) Patch
M src/objects-inl.h View 2 chunks +0 lines, -2 lines 0 comments Download
M test/cctest/test-constantpool.cc View 1 chunk +0 lines, -36 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
rmcilroy
Committed patchset #1 manually as r22598 (tree was closed).
6 years, 5 months ago (2014-07-24 12:31:00 UTC) #1
Yang
6 years, 5 months ago (2014-07-24 12:31:36 UTC) #2
Message was sent while issue was closed.
On 2014/07/24 12:31:00, rmcilroy wrote:
> Committed patchset #1 manually as r22598 (tree was closed).

lgtm.

Powered by Google App Engine
This is Rietveld 408576698