Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Issue 413143003: Selection popup is present even after focus is changed. (Closed)

Created:
6 years, 5 months ago by Cyan
Modified:
6 years, 4 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam, AKVT, AviD, ankit, kingshuk.j
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Selection popup is present even after focus is changed. Existing selection handles should be cleared when focus is changed from ContentView to URL.The issue seems happening because the selection is null.So, I have added the functionality to clear the handles even if selection is empty. BUG=397041 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=285940

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 22 (0 generated)
Cyan
@jdduke PTAL
6 years, 5 months ago (2014-07-24 09:09:37 UTC) #1
Cyan
On 2014/07/24 09:09:37, Cyan wrote: > @jdduke > PTAL @aurimas PTAL
6 years, 5 months ago (2014-07-24 14:42:18 UTC) #2
Cyan
On 2014/07/24 14:42:18, Cyan wrote: > On 2014/07/24 09:09:37, Cyan wrote: > > @jdduke > ...
6 years, 4 months ago (2014-07-25 15:06:34 UTC) #3
aurimas (slooooooooow)
lgtm
6 years, 4 months ago (2014-07-25 16:10:52 UTC) #4
Cyan
The CQ bit was checked by sayan.nayak@samsung.com
6 years, 4 months ago (2014-07-25 16:14:28 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sayan.nayak@samsung.com/413143003/1
6 years, 4 months ago (2014-07-25 16:15:24 UTC) #6
Cyan
On 2014/07/25 16:15:24, I haz the power (commit-bot) wrote: > CQ is trying da patch. ...
6 years, 4 months ago (2014-07-25 16:22:34 UTC) #7
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: chromium_presubmit on tryserver.chromium ...
6 years, 4 months ago (2014-07-25 17:27:45 UTC) #8
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-07-25 17:30:29 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/builds/82422)
6 years, 4 months ago (2014-07-25 17:30:30 UTC) #10
Cyan
The CQ bit was checked by sayan.nayak@samsung.com
6 years, 4 months ago (2014-07-25 17:56:44 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sayan.nayak@samsung.com/413143003/1
6 years, 4 months ago (2014-07-25 18:01:08 UTC) #12
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: chromium_presubmit on tryserver.chromium ...
6 years, 4 months ago (2014-07-25 18:05:49 UTC) #13
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-07-25 18:08:28 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/builds/82438)
6 years, 4 months ago (2014-07-25 18:08:29 UTC) #15
aurimas (slooooooooow)
On 2014/07/25 18:08:29, I haz the power (commit-bot) wrote: > Try jobs failed on following ...
6 years, 4 months ago (2014-07-25 18:23:29 UTC) #16
Cyan
On 2014/07/25 18:23:29, aurimas wrote: > On 2014/07/25 18:08:29, I haz the power (commit-bot) wrote: ...
6 years, 4 months ago (2014-07-25 19:13:31 UTC) #17
jdduke (slow)
On 2014/07/25 19:13:31, Cyan wrote: > On 2014/07/25 18:23:29, aurimas wrote: > > On 2014/07/25 ...
6 years, 4 months ago (2014-07-28 16:26:27 UTC) #18
Cyan
The CQ bit was checked by sayan.nayak@samsung.com
6 years, 4 months ago (2014-07-28 16:53:03 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sayan.nayak@samsung.com/413143003/1
6 years, 4 months ago (2014-07-28 16:53:54 UTC) #20
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: mac_chromium_rel on tryserver.chromium.mac ...
6 years, 4 months ago (2014-07-28 17:36:55 UTC) #21
commit-bot: I haz the power
6 years, 4 months ago (2014-07-28 17:42:06 UTC) #22
Message was sent while issue was closed.
Change committed as 285940

Powered by Google App Engine
This is Rietveld 408576698