|
|
DescriptionSelection popup is present even after focus is changed.
Existing selection handles should be cleared when
focus is changed from ContentView to URL.The issue
seems happening because the selection is null.So,
I have added the functionality to clear the handles
even if selection is empty.
BUG=397041
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=285940
Patch Set 1 #
Messages
Total messages: 22 (0 generated)
@jdduke PTAL
On 2014/07/24 09:09:37, Cyan wrote: > @jdduke > PTAL @aurimas PTAL
On 2014/07/24 14:42:18, Cyan wrote: > On 2014/07/24 09:09:37, Cyan wrote: > > @jdduke > > PTAL > > @aurimas > PTAL @jdduke PTAL
lgtm
The CQ bit was checked by sayan.nayak@samsung.com
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sayan.nayak@samsung.com/413143003/1
On 2014/07/25 16:15:24, I haz the power (commit-bot) wrote: > CQ is trying da patch. Follow status at > https://chromium-status.appspot.com/cq/sayan.nayak@samsung.com/413143003/1 chromium_presubmit is failing.It needs LGTM from one of the authors. @jdduke PTAL
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: chromium_presubmit on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/bu...)
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/bu...)
The CQ bit was checked by sayan.nayak@samsung.com
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sayan.nayak@samsung.com/413143003/1
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: chromium_presubmit on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/bu...)
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/bu...)
On 2014/07/25 18:08:29, I haz the power (commit-bot) wrote: > Try jobs failed on following builders: > chromium_presubmit on tryserver.chromium > (http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/bu...) You need OWNERS approval and I am not an owner of this directory. You will have to wait for jdduke@
On 2014/07/25 18:23:29, aurimas wrote: > On 2014/07/25 18:08:29, I haz the power (commit-bot) wrote: > > Try jobs failed on following builders: > > chromium_presubmit on tryserver.chromium > > > (http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/bu...) > > You need OWNERS approval and I am not an owner of this directory. You will have > to wait for jdduke@ @aurimas: thanks @jdduke: PTAL
On 2014/07/25 19:13:31, Cyan wrote: > On 2014/07/25 18:23:29, aurimas wrote: > > On 2014/07/25 18:08:29, I haz the power (commit-bot) wrote: > > > Try jobs failed on following builders: > > > chromium_presubmit on tryserver.chromium > > > > > > (http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/bu...) > > > > You need OWNERS approval and I am not an owner of this directory. You will > have > > to wait for jdduke@ > > @aurimas: thanks > @jdduke: PTAL lgtm
The CQ bit was checked by sayan.nayak@samsung.com
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sayan.nayak@samsung.com/413143003/1
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: mac_chromium_rel on tryserver.chromium.mac (http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel/...)
Message was sent while issue was closed.
Change committed as 285940 |