Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(67)

Issue 413133008: Remove Traversal<Element> specializations for lastWithin() / previous() (Closed)

Created:
6 years, 5 months ago by Inactive
Modified:
6 years, 4 months ago
CC:
blink-reviews, blink-reviews-dom_chromium.org, dglazkov+blink, eae+blinkwatch, rwlbuis, sof
Project:
blink
Visibility:
Public.

Description

Remove Traversal<Element> specializations for lastWithin() / previous() Remove Traversal<Element> template specializations for lastWithin() / previous() as they are now identical to the generic implementations after r178540. R=esprehn@chromium.org, abarth@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=179064

Patch Set 1 #

Patch Set 2 : Include fix for lastWithin() until it lands #

Patch Set 3 : Fix build error #

Patch Set 4 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -30 lines) Patch
M Source/core/dom/ElementTraversal.h View 1 2 3 2 chunks +0 lines, -30 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Inactive
Should land after the following bug fix: https://codereview.chromium.org/416933002/
6 years, 5 months ago (2014-07-24 19:00:43 UTC) #1
Inactive
On 2014/07/24 19:00:43, Chris Dumez wrote: > Should land after the following bug fix: > ...
6 years, 4 months ago (2014-07-28 21:40:11 UTC) #2
esprehn
lgtm
6 years, 4 months ago (2014-07-28 22:00:39 UTC) #3
Inactive
The CQ bit was checked by ch.dumez@samsung.com
6 years, 4 months ago (2014-07-28 22:15:56 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/413133008/60001
6 years, 4 months ago (2014-07-28 22:16:37 UTC) #5
commit-bot: I haz the power
6 years, 4 months ago (2014-07-28 23:25:01 UTC) #6
Message was sent while issue was closed.
Change committed as 179064

Powered by Google App Engine
This is Rietveld 408576698