ServiceWorker: Implement ServiceWorkerRegistration [1/3]

public/platform/WebServiceWorkerProvider.h

Index: public/platform/WebServiceWorkerProvider.h
diff --git a/public/platform/WebServiceWorkerProvider.h b/public/platform/WebServiceWorkerProvider.h
index 7fb36b2844fb5dab4b4ad9ec249b0ba9ad97c8d2..8107e143a85cada5784937fae6a33d66eecf5c9f 100644
--- a/public/platform/WebServiceWorkerProvider.h
+++ b/public/platform/WebServiceWorkerProvider.h
@@ -39,6 +39,7 @@ class WebString;
 class WebURL;
 class WebServiceWorker;
 class WebServiceWorkerProviderClient;
+class WebServiceWorkerRegistration;
 struct WebServiceWorkerError;
 
 // Created on the main thread, and may be passed to another script context
@@ -49,15 +50,24 @@ public:
     // Called when a client wants to start listening to the service worker events. Must be cleared before the client becomes invalid.
     virtual void setClient(WebServiceWorkerProviderClient*) { }
 
+    // FIXME: Remove this macro after two-side patches are landed (http://crbug.com/396400).

[tkent, 2014/07/25 07:50:24]

nit: I recommend to wrap code comments in 80 columns.

[nhiroki, 2014/07/25 08:28:57]

Done.

+#define DISABLE_SERVICE_WORKER_REGISTRATION
+#ifdef DISABLE_SERVICE_WORKER_REGISTRATION
     // The WebServiceWorker and WebServiceWorkerError ownership are passed to the WebServiceWorkerCallbacks implementation.
     typedef WebCallbacks<WebServiceWorker, WebServiceWorkerError> WebServiceWorkerCallbacks;
-    virtual void registerServiceWorker(const WebURL& pattern, const WebURL& scriptUrl, WebServiceWorkerCallbacks*) { }
+    typedef WebServiceWorkerCallbacks WebServiceWorkerRegistrationCallbacks;
+#else
+    // The WebServiceWorkerRegistration and WebServiceWorkerError ownership are passed to the WebServiceWorkerRegistrationCallbacks implementation.

[tkent, 2014/07/25 07:50:24]

Ditto.

[nhiroki, 2014/07/25 08:28:56]

Done.

+    typedef WebCallbacks<WebServiceWorkerRegistration, WebServiceWorkerError> WebServiceWorkerRegistrationCallbacks;
+#endif
+
+    virtual void registerServiceWorker(const WebURL& pattern, const WebURL& scriptUrl, WebServiceWorkerRegistrationCallbacks*) { }
 
     // Unregisters the ServiceWorker for a given scope. The provider
     // must always pass null to onSuccess.
-    // FIXME: "unregister" does not provide a WebServiceWorker, revisit this
-    // to clean up the the callback type to not take a WebServiceWorker*.
-    virtual void unregisterServiceWorker(const WebURL& pattern, WebServiceWorkerCallbacks*) { }
+    // FIXME: "unregister" does not provide a WebServiceWorkerRegistration, revisit this

[tkent, 2014/07/25 07:50:24]

Ditto.

[nhiroki, 2014/07/25 08:28:56]

Done.

+    // to clean up the the callback type to not take a WebServiceWorkerRegistration*.
+    virtual void unregisterServiceWorker(const WebURL& pattern, WebServiceWorkerRegistrationCallbacks*) { }
 
     virtual ~WebServiceWorkerProvider() { }
 };