Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(199)

Side by Side Diff: chrome/browser/extensions/api/feedback_private/feedback_browsertest.cc

Issue 413083002: Disable FeedbackTest.ShowFeedback on all platforms. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "apps/app_window.h" 5 #include "apps/app_window.h"
6 #include "apps/app_window_registry.h" 6 #include "apps/app_window_registry.h"
7 #include "base/bind.h" 7 #include "base/bind.h"
8 #include "chrome/browser/apps/app_browsertest_util.h" 8 #include "chrome/browser/apps/app_browsertest_util.h"
9 #include "chrome/browser/browser_process.h" 9 #include "chrome/browser/browser_process.h"
10 #include "chrome/browser/extensions/api/feedback_private/feedback_private_api.h" 10 #include "chrome/browser/extensions/api/feedback_private/feedback_private_api.h"
(...skipping 63 matching lines...) Expand 10 before | Expand all | Expand 10 after
74 void InvokeFeedbackUI() { 74 void InvokeFeedbackUI() {
75 extensions::FeedbackPrivateAPI* api = 75 extensions::FeedbackPrivateAPI* api =
76 extensions::FeedbackPrivateAPI::GetFactoryInstance()->Get( 76 extensions::FeedbackPrivateAPI::GetFactoryInstance()->Get(
77 browser()->profile()); 77 browser()->profile());
78 api->RequestFeedback("Test description", 78 api->RequestFeedback("Test description",
79 "Test tag", 79 "Test tag",
80 GURL("http://www.test.com")); 80 GURL("http://www.test.com"));
81 } 81 }
82 }; 82 };
83 83
84 // Disabled test; it is crashing on ChromeOS build bots intermittently.
85 // See http://crbug.com/369886. 84 // See http://crbug.com/369886.
86 #if defined(OS_CHROMEOS) 85 IN_PROC_BROWSER_TEST_F(FeedbackTest, DISABLED_ShowFeedback) {
87 #define MAYBE_ShowFeedback DISABLED_ShowFeedback
88 #else
89 #define MAYBE_ShowFeedback ShowFeedback
90 #endif
91
92 IN_PROC_BROWSER_TEST_F(FeedbackTest, MAYBE_ShowFeedback) {
93 WaitForExtensionViewsToLoad(); 86 WaitForExtensionViewsToLoad();
94 87
95 ASSERT_TRUE(IsFeedbackAppAvailable()); 88 ASSERT_TRUE(IsFeedbackAppAvailable());
96 StartFeedbackUI(); 89 StartFeedbackUI();
97 VerifyFeedbackAppLaunch(); 90 VerifyFeedbackAppLaunch();
98 } 91 }
99 92
100 } // namespace extensions 93 } // namespace extensions
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698