content/browser/service_worker/service_worker_unregister_job.h - Issue 413063004: Service Worker: in Unregister, wait until after the active worker no longer controls a document

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/service_worker/service_worker_unregister_job.h

Issue 413063004: Service Worker: in Unregister, wait until after the active worker no longer controls a document (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: address comments Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/service_worker/service_worker_registration.cc ('K') | « content/browser/service_worker/service_worker_storage.cc ('k') | content/browser/service_worker/service_worker_unregister_job.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/service_worker/service_worker_unregister_job.h

diff --git a/content/browser/service_worker/service_worker_unregister_job.h b/content/browser/service_worker/service_worker_unregister_job.h

index 0a1697aec2880e03c31b7038a576f545c4779335..5e627ae1a4e3a986fcf3ae1607100523e8dacf80 100644

--- a/content/browser/service_worker/service_worker_unregister_job.h

+++ b/content/browser/service_worker/service_worker_unregister_job.h

@@ -48,14 +48,14 @@ class ServiceWorkerUnregisterJob : public ServiceWorkerRegisterJobBase {

void OnRegistrationFound(

ServiceWorkerStatusCode status,

const scoped_refptr<ServiceWorkerRegistration>& registration);

- void DeleteRegistration(

- const scoped_refptr<ServiceWorkerRegistration>& registration);

void Complete(ServiceWorkerStatusCode status);

void CompleteInternal(ServiceWorkerStatusCode status);

+ void ResolvePromise(ServiceWorkerStatusCode status);

base::WeakPtr<ServiceWorkerContextCore> context_;

const GURL pattern_;

std::vector<UnregistrationCallback> callbacks_;

+ bool is_promise_resolved_;

base::WeakPtrFactory<ServiceWorkerUnregisterJob> weak_factory_;

DISALLOW_COPY_AND_ASSIGN(ServiceWorkerUnregisterJob);