Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1718)

Unified Diff: content/browser/service_worker/service_worker_storage.h

Issue 413063004: Service Worker: in Unregister, wait until after the active worker no longer controls a document (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: address comments Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/service_worker/service_worker_storage.h
diff --git a/content/browser/service_worker/service_worker_storage.h b/content/browser/service_worker/service_worker_storage.h
index 30db1e960c1ff13e7c2ec1333c6dcb5803b03072..369c7d8af9974f212816eaed2cbd156918e45c21 100644
--- a/content/browser/service_worker/service_worker_storage.h
+++ b/content/browser/service_worker/service_worker_storage.h
@@ -87,6 +87,8 @@ class CONTENT_EXPORT ServiceWorkerStorage
const GURL& origin,
const FindRegistrationCallback& callback);
+ ServiceWorkerRegistration* GetUninstallingRegistration(const GURL& scope);
+
// Returns info about all stored and initially installing registrations.
void GetAllRegistrations(const GetAllRegistrationInfosCallback& callback);
@@ -136,13 +138,17 @@ class CONTENT_EXPORT ServiceWorkerStorage
int64 NewVersionId();
int64 NewResourceId();
- // Intended for use only by ServiceWorkerRegisterJob.
+ // Intended for use only by ServiceWorkerRegisterJob and
+ // ServiceWorkerRegistration.
void NotifyInstallingRegistration(
ServiceWorkerRegistration* registration);
void NotifyDoneInstallingRegistration(
ServiceWorkerRegistration* registration,
ServiceWorkerVersion* version,
ServiceWorkerStatusCode status);
+ void NotifyUninstallingRegistration(ServiceWorkerRegistration* registration);
+ void NotifyDoneUninstallingRegistration(
+ ServiceWorkerRegistration* registration);
void Disable();
bool IsDisabled() const;
@@ -335,8 +341,9 @@ class CONTENT_EXPORT ServiceWorkerStorage
const StatusCallback& callback,
bool result);
- // For finding registrations being installed.
+ // For finding registrations being installed or uninstalled.
RegistrationRefsById installing_registrations_;
+ RegistrationRefsById uninstalling_registrations_;
// Origins having registations.
std::set<GURL> registered_origins_;

Powered by Google App Engine
This is Rietveld 408576698