content/browser/service_worker/service_worker_database.cc - Issue 413063004: Service Worker: in Unregister, wait until after the active worker no longer controls a document

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/service_worker/service_worker_database.cc

Issue 413063004: Service Worker: in Unregister, wait until after the active worker no longer controls a document (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: more cleanup Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | content/browser/service_worker/service_worker_register_job.cc » ('j') | content/browser/service_worker/service_worker_register_job.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/service_worker/service_worker_database.cc

diff --git a/content/browser/service_worker/service_worker_database.cc b/content/browser/service_worker/service_worker_database.cc

index 51b4cb3414377cfecfdfa906db66f06f90009925..cd0d959ef473ab200f9e346b28a31d46bef5a632 100644

--- a/content/browser/service_worker/service_worker_database.cc

+++ b/content/browser/service_worker/service_worker_database.cc

@@ -513,6 +513,9 @@ ServiceWorkerDatabase::Status ServiceWorkerDatabase::WriteRegistration(

// Delete a resource from the uncommitted list.

batch.Delete(CreateResourceIdKey(

kUncommittedResIdKeyPrefix, itr->resource_id));

+ // Delete from the purgeable list in case this version was once deleted.

+ batch.Delete(

+ CreateResourceIdKey(kPurgeableResIdKeyPrefix, itr->resource_id));

}

// Retrieve a previous version to sweep purgeable resources.