Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(209)

Issue 413063003: Revert 285028 "Pepper: Remove LOAD_MODULE SRPC call in SFI mode." (Closed)

Created:
6 years, 5 months ago by Derek Bruening
Modified:
6 years, 5 months ago
Reviewers:
teravest
CC:
chromium-reviews
Visibility:
Public.

Description

Revert 285028 "Pepper: Remove LOAD_MODULE SRPC call in SFI mode." Reason for revert: r285028 seems to have broken the ThreadSanitizer build. > Pepper: Remove LOAD_MODULE SRPC call in SFI mode. > > This change puts nexe information in the parameters for starting a NaCl > plugin instead of sending that information over SRPC. This may remove the > need for that IPC round trip entirely; perhaps we could report load failure > as part of the RPCs for starting sel_ldr or performing StartModule(). > > nacl_defines.gypi as added as a dependency in components/components_tests.gyp > because nacl_process_host.h now includes > "native_client/src/public/nacl_file_info.h", which requires nacl_defines. > > BUG=333950 > R=bbudge@chromium.org, brettw@chromium.org, hidehiko@chromium.org, jschuh@chromium.org, mseaborn@chromium.org, sky@chromium.org > > Review URL: https://codereview.chromium.org/332463003 TBR=teravest@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=285120

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+129 lines, -143 lines) Patch
M trunk/src/chrome/browser/BUILD.gn View 2 chunks +2 lines, -2 lines 0 comments Download
M trunk/src/components/components_tests.gyp View 1 chunk +0 lines, -6 lines 0 comments Download
M trunk/src/components/nacl/browser/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
M trunk/src/components/nacl/browser/nacl_host_message_filter.cc View 1 chunk +2 lines, -32 lines 0 comments Download
M trunk/src/components/nacl/browser/nacl_process_host.h View 4 chunks +0 lines, -5 lines 0 comments Download
M trunk/src/components/nacl/browser/nacl_process_host.cc View 5 chunks +11 lines, -11 lines 0 comments Download
M trunk/src/components/nacl/common/nacl_host_messages.h View 1 chunk +0 lines, -2 lines 0 comments Download
M trunk/src/components/nacl/common/nacl_messages.h View 1 chunk +0 lines, -2 lines 0 comments Download
M trunk/src/components/nacl/common/nacl_types.h View 4 chunks +1 line, -11 lines 0 comments Download
M trunk/src/components/nacl/common/nacl_types.cc View 5 chunks +12 lines, -8 lines 0 comments Download
M trunk/src/components/nacl/loader/nacl_listener.cc View 5 chunks +1 line, -20 lines 0 comments Download
M trunk/src/components/nacl/renderer/ppb_nacl_private_impl.cc View 1 chunk +3 lines, -16 lines 0 comments Download
M trunk/src/ppapi/native_client/src/trusted/plugin/plugin.h View 2 chunks +7 lines, -4 lines 0 comments Download
M trunk/src/ppapi/native_client/src/trusted/plugin/plugin.cc View 8 chunks +37 lines, -13 lines 0 comments Download
M trunk/src/ppapi/native_client/src/trusted/plugin/service_runtime.h View 2 chunks +5 lines, -3 lines 0 comments Download
M trunk/src/ppapi/native_client/src/trusted/plugin/service_runtime.cc View 2 chunks +48 lines, -7 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Derek Bruening
6 years, 5 months ago (2014-07-24 02:34:29 UTC) #1
Derek Bruening
6 years, 5 months ago (2014-07-24 02:35:10 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 manually as r285120.

Powered by Google App Engine
This is Rietveld 408576698