Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(317)

Issue 413033003: Always create OEM folder, update position after sync (Closed)

Created:
6 years, 5 months ago by stevenjb
Modified:
6 years, 5 months ago
Reviewers:
jennyz
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org, tfarina
Project:
chromium
Visibility:
Public.

Description

Always create OEM folder, update position after sync Because initial sync may take as long as 10 minutes to occur for new accounts, do not defer creation of the OEM folder, instead re-position it when sync data arrives. BUG=chrome-os-partner:29764 R=jennyz@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=285606

Patch Set 1 #

Patch Set 2 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -32 lines) Patch
M chrome/browser/ui/app_list/app_list_syncable_service.h View 2 chunks +2 lines, -5 lines 0 comments Download
M chrome/browser/ui/app_list/app_list_syncable_service.cc View 1 4 chunks +11 lines, -27 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
stevenjb
6 years, 5 months ago (2014-07-24 01:20:35 UTC) #1
jennyz
lgtm
6 years, 5 months ago (2014-07-24 16:39:17 UTC) #2
stevenjb
The CQ bit was checked by stevenjb@chromium.org
6 years, 5 months ago (2014-07-24 18:02:34 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/stevenjb@chromium.org/413033003/20001
6 years, 5 months ago (2014-07-24 18:08:21 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_chromium_chromeos_rel on tryserver.chromium ...
6 years, 5 months ago (2014-07-24 21:28:38 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-24 22:01:16 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_swarming on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_rel_swarming/builds/2099)
6 years, 5 months ago (2014-07-24 22:01:17 UTC) #7
stevenjb
6 years, 5 months ago (2014-07-25 17:11:37 UTC) #8
Message was sent while issue was closed.
Committed patchset #2 manually as r285606 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698