Issue 412993002: Get additional DW font metrics when available.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 412993002: Get additional DW font metrics when available. (Closed)

Created:
6 years, 5 months ago by bungeman-skia

Modified:
6 years, 5 months ago

Reviewers:
eae, caryclark

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@master

Project:
skia

Visibility:
Public.

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+39 lines, -5 lines)			Patch
	M	src/ports/SkScalerContext_win_dw.cpp	View	1	4 chunks	+30 lines, -4 lines	0 comments	Download
	M	src/ports/SkTypeface_win_dw.h	View	1 2	3 chunks	+9 lines, -1 line	0 comments	Download

Total messages: 6 (0 generated)

caryclark

lgtm (with oral feedback that it should crash instead of assert)

6 years, 5 months ago (2014-07-23 20:03:43 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/bungeman@google.com/412993002/40001

6 years, 5 months ago (2014-07-23 20:18:55 UTC) #4

commit-bot: I haz the power

Change committed as f73c237291bb1fc698f688d8a9b1cdd23838ed18

6 years, 5 months ago (2014-07-23 20:31:11 UTC) #5

Message was sent while issue was closed.

Nice, thank you Ben!

LGTM