Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(860)

Issue 412983002: Migrate WorkItemListTest to use RegistryOverrideManager instead of rolling its own attempt at temp … (Closed)

Created:
6 years, 5 months ago by robertshield
Modified:
6 years, 4 months ago
Reviewers:
grt (UTC plus 2)
CC:
chromium-reviews, grt+watch_chromium.org
Project:
chromium
Visibility:
Public.

Description

Migrate WorkItemListTest to use RegistryOverrideManager instead of rolling its own attempt at temp registry keys. BUG=396405 TEST=installer_util_unittest.exe Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=285310

Patch Set 1 #

Patch Set 2 : Rebase, reenable tests. #

Total comments: 1

Patch Set 3 : Retry against updated LKGR #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -15 lines) Patch
M chrome/installer/util/work_item_list_unittest.cc View 1 3 chunks +5 lines, -15 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
robertshield
PTAL, don't know what happened to the bots after the rebase, will rebase again and ...
6 years, 5 months ago (2014-07-23 21:43:59 UTC) #1
grt (UTC plus 2)
On 2014/07/23 21:43:59, robertshield wrote: > PTAL, don't know what happened to the bots after ...
6 years, 5 months ago (2014-07-23 21:50:29 UTC) #2
grt (UTC plus 2)
lgtm https://codereview.chromium.org/412983002/diff/20001/chrome/installer/util/work_item_list_unittest.cc File chrome/installer/util/work_item_list_unittest.cc (right): https://codereview.chromium.org/412983002/diff/20001/chrome/installer/util/work_item_list_unittest.cc#newcode32 chrome/installer/util/work_item_list_unittest.cc:32: registry_override_manager_.OverrideRegistry(HKEY_CURRENT_USER, L"root_pit"); this is so much better. thank ...
6 years, 5 months ago (2014-07-23 22:03:59 UTC) #3
robertshield
The CQ bit was checked by robertshield@chromium.org
6 years, 4 months ago (2014-07-24 13:35:19 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/robertshield@chromium.org/412983002/40001
6 years, 4 months ago (2014-07-24 13:37:56 UTC) #5
commit-bot: I haz the power
6 years, 4 months ago (2014-07-24 17:23:34 UTC) #6
Message was sent while issue was closed.
Change committed as 285310

Powered by Google App Engine
This is Rietveld 408576698