pkg/polymer/lib/deserialize.dart - Issue 41293002: Fixes from polymer.dart API review

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/polymer/lib/deserialize.dart

Issue 41293002: Fixes from polymer.dart API review (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Made Job a part of polymer Created 7 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: pkg/polymer/lib/deserialize.dart

diff --git a/pkg/polymer/lib/deserialize.dart b/pkg/polymer/lib/deserialize.dart

index 0abd1b1c59bcdf3d4bc72921c8fd4cb647442f40..60e63f7588ccfa43c502f45f0464544672d18dbc 100644

--- a/pkg/polymer/lib/deserialize.dart

+++ b/pkg/polymer/lib/deserialize.dart

@@ -12,13 +12,13 @@ final _typeHandlers = () {

var m = new Map();

m[#dart.core.String] = (x, _) => x;

m[#dart.core.Null] = (x, _) => x;

- m[#dart.core.DateTime] = (x, _) {

+ m[#dart.core.DateTime] = (x, def) {

// TODO(jmesserly): shouldn't need to try-catch here

// See: https://code.google.com/p/dart/issues/detail?id=1878

try {

return DateTime.parse(x);

} catch (e) {

- return new DateTime.now();

+ return def;

}

};

m[#dart.core.bool] = (x, _) => x != 'false';