Fixes from polymer.dart API review

pkg/polymer/lib/src/instance.dart

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 part of polymer;
 
 /**
  * Use this annotation to publish a field as an attribute. For example:
  *
  *     class MyPlaybackElement extends PolymerElement {
@@ skipping 64 matching lines @@
    */
   static Future get onReady => _ready.future;
 
   PolymerDeclaration _declaration;
 
   /** The most derived `<polymer-element>` declaration for this element. */
   PolymerDeclaration get declaration => _declaration;
 
   Map<String, StreamSubscription> _observers;
   bool _unbound; // lazy-initialized
-  Job _unbindAllJob;
+  _Job _unbindAllJob;
 
   StreamSubscription _propertyObserver;
 
   bool get _elementPrepared => _declaration != null;
 
   bool get applyAuthorStyles => false;
   bool get resetStyleInheritance => false;
   bool get alwaysPrepare => false;
   bool get preventDispose => false;
 
@@ skipping 18 matching lines @@
    * Gets the shadow root associated with the corresponding custom element.
    *
    * This is identical to [shadowRoot], unless there are multiple levels of
    * inheritance and they each have their own shadow root. For example,
    * this can happen if the base class and subclass both have `<template>` tags
    * in their `<polymer-element>` tags.
    */
   // TODO(jmesserly): Polymer does not have this feature. Reconcile.
   ShadowRoot getShadowRoot(String customTagName) => _shadowRoots[customTagName];
 
-  /**
-   * Invoke [callback] in [wait], unless the job is re-registered,
-   * which resets the timer. For example:
-   *
-   *     _myJob = job(_myJob, callback, const Duration(milliseconds: 100));
-   *
-   * Returns a job handle which can be used to re-register a job.
-   */
-  Job job(Job job, void callback(), Duration wait) =>
-      runJob(job, callback, wait);
-
   void polymerCreated() {
     if (this.ownerDocument.window != null || alwaysPrepare ||
         _preparingElements > 0) {
       prepareElement();
     }
   }
 
   /** Retrieves the custom element name by inspecting the host node. */
   String get _customTagName {
     var isAttr = attributes['is'];
@@ skipping 303 matching lines @@
     }
   }
 
   Map<String, NodeBinding> get bindings => nodeBindFallback(this).bindings;
 
   void unbind(String name) => nodeBindFallback(this).unbind(name);
 
   void asyncUnbindAll() {
     if (_unbound == true) return;
     _unbindLog.fine('[$localName] asyncUnbindAll');
-    _unbindAllJob = job(_unbindAllJob, unbindAll, const Duration(seconds: 0));
+    _unbindAllJob = _runJob(_unbindAllJob, unbindAll, Duration.ZERO);
   }
 
   void unbindAll() {
     if (_unbound == true) return;
 
     unbindAllProperties();
     nodeBindFallback(this).unbindAll();
 
     var root = shadowRoot;
     while (root != null) {
@@ skipping 413 matching lines @@
    *
    * If you would prefer to run the callback using
    * [window.requestAnimationFrame], see the [async] method.
    */
   // Dart note: "async" is split into 2 methods so it can have a sensible type
   // signatures. Also removed the various features that don't make sense in a
   // Dart world, like binding to "this" and taking arguments list.
   Timer asyncTimer(void method(), Duration timeout) {
     // when polyfilling Object.observe, ensure changes
     // propagate before executing the async method
-    platform.flush();
+    scheduleMicrotask(Observable.dirtyCheck);
     return new Timer(timeout, method);
   }
 
   /**
    * Invokes a function asynchronously.
    * This will call `Platform.flush()` and then call
    * [window.requestAnimationFrame] with the provided [method] and return the
    * result.
    *
    * If you would prefer to run the callback after a given duration, see
    * the [asyncTimer] method.
    */
   int async(RequestAnimationFrameCallback method) {
     // when polyfilling Object.observe, ensure changes
     // propagate before executing the async method
-    platform.flush();
+    scheduleMicrotask(Observable.dirtyCheck);
     return window.requestAnimationFrame(method);
   }
 
   /**
    * Fire a [CustomEvent] targeting [toNode], or this if toNode is not
    * supplied. Returns the [detail] object.
    */
   Object fire(String type, {Object detail, Node toNode, bool canBubble}) {
     var node = toNode != null ? toNode : this;
     //log.events && console.log('[%s]: sending [%s]', node.localName, inType);
@@ skipping 219 matching lines @@
 class PolymerElement extends HtmlElement with Polymer, Observable {
   PolymerElement.created() : super.created() {
     polymerCreated();
   }
 }
 
 class _PropertyValue {
   Object oldValue, newValue;
   _PropertyValue(this.oldValue);
 }