Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(101)

Side by Side Diff: src/x87/stub-cache-x87.cc

Issue 412903003: X87: Always use the LoadStubCompiler for Load handlers, also for keyedload handlers (Closed) Base URL: https://chromium.googlesource.com/external/v8.git@bleeding_edge
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/v8.h" 5 #include "src/v8.h"
6 6
7 #if V8_TARGET_ARCH_X87 7 #if V8_TARGET_ARCH_X87
8 8
9 #include "src/codegen.h" 9 #include "src/codegen.h"
10 #include "src/ic-inl.h" 10 #include "src/ic-inl.h"
(...skipping 949 matching lines...) Expand 10 before | Expand all | Expand 10 after
960 HandlerFrontendFooter(name, &miss); 960 HandlerFrontendFooter(name, &miss);
961 return reg; 961 return reg;
962 } 962 }
963 963
964 964
965 void LoadStubCompiler::GenerateLoadField(Register reg, 965 void LoadStubCompiler::GenerateLoadField(Register reg,
966 Handle<JSObject> holder, 966 Handle<JSObject> holder,
967 FieldIndex field, 967 FieldIndex field,
968 Representation representation) { 968 Representation representation) {
969 if (!reg.is(receiver())) __ mov(receiver(), reg); 969 if (!reg.is(receiver())) __ mov(receiver(), reg);
970 if (kind() == Code::LOAD_IC) { 970 LoadFieldStub stub(isolate(), field);
971 LoadFieldStub stub(isolate(), field); 971 GenerateTailCall(masm(), stub.GetCode());
972 GenerateTailCall(masm(), stub.GetCode());
973 } else {
974 KeyedLoadFieldStub stub(isolate(), field);
975 GenerateTailCall(masm(), stub.GetCode());
976 }
977 } 972 }
978 973
979 974
980 void LoadStubCompiler::GenerateLoadCallback( 975 void LoadStubCompiler::GenerateLoadCallback(
981 Register reg, 976 Register reg,
982 Handle<ExecutableAccessorInfo> callback) { 977 Handle<ExecutableAccessorInfo> callback) {
983 // Insert additional parameters into the stack frame above return address. 978 // Insert additional parameters into the stack frame above return address.
984 ASSERT(!scratch3().is(reg)); 979 ASSERT(!scratch3().is(reg));
985 __ pop(scratch3()); // Get return address to place it below. 980 __ pop(scratch3()); // Get return address to place it below.
986 981
(...skipping 513 matching lines...) Expand 10 before | Expand all | Expand 10 after
1500 // ----------------------------------- 1495 // -----------------------------------
1501 TailCallBuiltin(masm, Builtins::kKeyedLoadIC_Miss); 1496 TailCallBuiltin(masm, Builtins::kKeyedLoadIC_Miss);
1502 } 1497 }
1503 1498
1504 1499
1505 #undef __ 1500 #undef __
1506 1501
1507 } } // namespace v8::internal 1502 } } // namespace v8::internal
1508 1503
1509 #endif // V8_TARGET_ARCH_X87 1504 #endif // V8_TARGET_ARCH_X87
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698