Separate out the TtsController interface from it's impl

Separate out the TtsController interface from it's impl

Create TtsControllerImpl so that TtsController can serve
as TTS interface once it is moved to content in future.
The approach is similar to SpeechRecognitionManager.
This is part of an effort to move TTS to content.

BUG=347045
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=285169

[dmazzoni, 2014-07-23 05:57:35]

lgtm

[dmazzoni, 2014-07-23 05:58:32]

The CQ bit was checked by dmazzoni@chromium.org

[commit-bot: I haz the power, 2014-07-23 05:59:19]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/mrunal.kapade@intel.com/412783002/1

[commit-bot: I haz the power, 2014-07-23 07:11:22]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  linux_chromium_chromeos_clang_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chrome...)
  linux_chromium_chromeos_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chrome...)
  linux_chromium_clang_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_clang_...)
  linux_chromium_rel_swarming on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_rel_sw...)
  mac_chromium_compile_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/mac_chromium_compile_...)
  mac_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/mac_chromium_rel/buil...)
  win8_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win8_chromium_rel/bui...)
  win_chromium_compile_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_compile_...)
  win_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/buil...)
  win_chromium_x64_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_x64_rel/...)

[commit-bot: I haz the power, 2014-07-23 07:20:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-07-23 07:20:13]

Try jobs failed on following builders:
  linux_chromium_rel_swarming on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_rel_sw...)

[sky, 2014-07-23 16:34:37]

LGTM

https://codereview.chromium.org/412783002/diff/1/chrome/browser/speech/tts_co...
File chrome/browser/speech/tts_controller_impl.h (right):

https://codereview.chromium.org/412783002/diff/1/chrome/browser/speech/tts_co...
chrome/browser/speech/tts_controller_impl.h:5: #ifndef
CHROME_BROWSER_SPEECH_TTS_CONTROLLER_IMPL_H_
I'm surprised this file didn't show up as a copy.

https://codereview.chromium.org/412783002/diff/1/chrome/browser/speech/tts_co...
chrome/browser/speech/tts_controller_impl.h:28: virtual bool IsSpeaking()
OVERRIDE;
overrides are grouped together with no comments. See other classes for what I
mean.

[mrunal, 2014-07-23 17:17:06]

https://codereview.chromium.org/412783002/diff/1/chrome/browser/speech/tts_co...
File chrome/browser/speech/tts_controller_impl.h (right):

https://codereview.chromium.org/412783002/diff/1/chrome/browser/speech/tts_co...
chrome/browser/speech/tts_controller_impl.h:5: #ifndef
CHROME_BROWSER_SPEECH_TTS_CONTROLLER_IMPL_H_
Do u mean above header name is duplicate? or Do u mean contents of this file are
mostly copied?

https://codereview.chromium.org/412783002/diff/1/chrome/browser/speech/tts_co...
chrome/browser/speech/tts_controller_impl.h:28: virtual bool IsSpeaking()
OVERRIDE;
On 2014/07/23 16:34:37, sky wrote:
> overrides are grouped together with no comments. See other classes for what I
> mean.

Acknowledged.

[sky, 2014-07-23 19:11:07]

https://codereview.chromium.org/412783002/diff/1/chrome/browser/speech/tts_co...
File chrome/browser/speech/tts_controller_impl.h (right):

https://codereview.chromium.org/412783002/diff/1/chrome/browser/speech/tts_co...
chrome/browser/speech/tts_controller_impl.h:5: #ifndef
CHROME_BROWSER_SPEECH_TTS_CONTROLLER_IMPL_H_
On 2014/07/23 17:17:06, mrunal wrote:
> Do u mean above header name is duplicate? or Do u mean contents of this file
are
> mostly copied?

I meant that is this file is basically of a copy of what was in tts_controller.h
I expected it to show as a copy.

[mrunal, 2014-07-23 19:18:26]

https://codereview.chromium.org/412783002/diff/1/chrome/browser/speech/tts_co...
File chrome/browser/speech/tts_controller_impl.h (right):

https://codereview.chromium.org/412783002/diff/1/chrome/browser/speech/tts_co...
chrome/browser/speech/tts_controller_impl.h:5: #ifndef
CHROME_BROWSER_SPEECH_TTS_CONTROLLER_IMPL_H_
Got it.

[sky, 2014-07-23 19:23:24]

LGTM

https://codereview.chromium.org/412783002/diff/20001/chrome/browser/speech/tt...
File chrome/browser/speech/tts_controller_impl.h (right):

https://codereview.chromium.org/412783002/diff/20001/chrome/browser/speech/tt...
chrome/browser/speech/tts_controller_impl.h:27: virtual bool IsSpeaking()
OVERRIDE;
nit: We generally prefix overrides sections with something like:

// TtsController overrides:

(see chrome style guide for specifics).

[mrunal, 2014-07-23 23:03:10]

It looks like I haven't got the trybot access yet? Can you please start the
trybots again. Thanks.

[mrunal, 2014-07-24 00:10:51]

The CQ bit was checked by mrunal.kapade@intel.com

[commit-bot: I haz the power, 2014-07-24 00:13:27]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/mrunal.kapade@intel.com/412783002/40001

[commit-bot: I haz the power, 2014-07-24 10:28:53]

Change committed as 285169