Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(119)

Issue 412773002: Copy expect_tests from build (Closed)

Created:
6 years, 5 months ago by iannucci
Modified:
6 years, 5 months ago
Reviewers:
Vadim Sh., agable
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/infra/testing/expect_tests@master
Visibility:
Public.

Description

Copy expect_tests from build Add setup.py, requirements.txt, and remove build-specific imports. R=agable@chromium.org, vadimsh@chromium.org BUG= Committed: https://chromium.googlesource.com/infra/testing/expect_tests/+/fcd5ac6

Patch Set 1 : #

Patch Set 2 : fix relative imports #

Patch Set 3 : Add requirements to setup() #

Patch Set 4 : Fancy ast walker #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1578 lines, -0 lines) Patch
A .gitignore View 1 chunk +1 line, -0 lines 0 comments Download
A README.md View 1 chunk +7 lines, -0 lines 0 comments Download
A expect_tests/__init__.py View 1 1 chunk +18 lines, -0 lines 0 comments Download
A expect_tests/cover.py View 1 chunk +85 lines, -0 lines 0 comments Download
A expect_tests/handle_debug.py View 1 1 chunk +42 lines, -0 lines 0 comments Download
A expect_tests/handle_list.py View 1 1 chunk +33 lines, -0 lines 0 comments Download
A expect_tests/handle_test.py View 1 1 chunk +113 lines, -0 lines 0 comments Download
A expect_tests/handle_train.py View 1 1 chunk +153 lines, -0 lines 0 comments Download
A expect_tests/main.py View 1 1 chunk +163 lines, -0 lines 0 comments Download
A expect_tests/pipeline.py View 1 1 chunk +252 lines, -0 lines 0 comments Download
A expect_tests/serialize.py View 1 chunk +127 lines, -0 lines 0 comments Download
A expect_tests/type_definitions.py View 1 chunk +425 lines, -0 lines 0 comments Download
A expect_tests/unittest_helper.py View 1 1 chunk +95 lines, -0 lines 0 comments Download
A expect_tests/util.py View 1 chunk +24 lines, -0 lines 0 comments Download
A requirements.txt View 1 chunk +1 line, -0 lines 0 comments Download
A setup.py View 1 2 3 1 chunk +39 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
iannucci
PTAL, no real changes
6 years, 5 months ago (2014-07-23 02:51:20 UTC) #1
iannucci
+vadim (this one precedes the other one. I'll do setup.py changes here)
6 years, 5 months ago (2014-07-23 04:27:07 UTC) #2
iannucci
PTAL
6 years, 5 months ago (2014-07-23 04:28:13 UTC) #3
iannucci
PTAL (again). Uses ast to read vars from expect_tests/__init__.py to avoid importing coverage during setup.py ...
6 years, 5 months ago (2014-07-23 05:07:30 UTC) #4
Vadim Sh.
lgtm
6 years, 5 months ago (2014-07-23 17:50:36 UTC) #5
agable
lgtm
6 years, 5 months ago (2014-07-23 18:33:05 UTC) #6
iannucci
6 years, 5 months ago (2014-07-23 18:55:46 UTC) #7
Message was sent while issue was closed.
Committed patchset #4 manually as rfcd5ac6 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698