Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(107)

Issue 412763002: Make Crypto and Service Worker use the same message for secure origins. (Closed)

Created:
6 years, 5 months ago by dominicc (has gone to gerrit)
Modified:
6 years, 5 months ago
Reviewers:
eroman, abarth-chromium
CC:
alecflett+watch_chromium.org, blink-reviews, falken, horo+watch_chromium.org, jsbell+serviceworker_chromium.org, kinuko+serviceworker, michaeln, Mike West, nhiroki, Chris Palmer, serviceworker-reviews, tzik
Project:
blink
Visibility:
Public.

Description

Make Crypto and Service Worker use the same message for secure origins. BUG=395348, 394213 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=178827

Patch Set 1 #

Total comments: 1

Patch Set 2 : Remove the now redundant blink:: this touched. #

Patch Set 3 : Bring patch to head. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -13 lines) Patch
M Source/modules/crypto/SubtleCrypto.cpp View 1 2 1 chunk +3 lines, -2 lines 0 comments Download
M Source/modules/serviceworkers/ServiceWorkerContainer.cpp View 1 2 2 chunks +6 lines, -4 lines 0 comments Download
M Source/modules/serviceworkers/ServiceWorkerContainerTest.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/platform/weborigin/SecurityOrigin.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/weborigin/SecurityOrigin.cpp View 1 chunk +6 lines, -2 lines 0 comments Download
M Source/platform/weborigin/SecurityOriginTest.cpp View 1 chunk +6 lines, -2 lines 0 comments Download

Messages

Total messages: 17 (0 generated)
dominicc (has gone to gerrit)
PTAL This assumes https://codereview.chromium.org/400903002/ goes first.
6 years, 5 months ago (2014-07-23 02:36:51 UTC) #1
abarth-chromium
lgtm https://codereview.chromium.org/412763002/diff/1/Source/modules/crypto/SubtleCrypto.cpp File Source/modules/crypto/SubtleCrypto.cpp (right): https://codereview.chromium.org/412763002/diff/1/Source/modules/crypto/SubtleCrypto.cpp#newcode83 Source/modules/crypto/SubtleCrypto.cpp:83: result->completeWithError(blink::WebCryptoErrorTypeNotSupported, errorMessage); No need for "blink::" anymore.
6 years, 5 months ago (2014-07-23 04:21:07 UTC) #2
dominicc (has gone to gerrit)
https://codereview.chromium.org/400903002/ is in, so eroman if this LG could you commit queue it? On 2014/07/23 ...
6 years, 5 months ago (2014-07-23 05:15:40 UTC) #3
abarth-chromium
On 2014/07/23 at 05:15:40, dominicc wrote: > Done, although it feels weird to remove just ...
6 years, 5 months ago (2014-07-23 05:41:53 UTC) #4
eroman
lgtm
6 years, 5 months ago (2014-07-24 00:14:01 UTC) #5
dominicc (has gone to gerrit)
The CQ bit was checked by dominicc@chromium.org
6 years, 5 months ago (2014-07-24 00:15:38 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dominicc@chromium.org/412763002/20001
6 years, 5 months ago (2014-07-24 00:16:38 UTC) #7
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_gpu_triggered_tests on tryserver.chromium.gpu ...
6 years, 5 months ago (2014-07-24 06:30:04 UTC) #8
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-24 06:48:57 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: win_gpu_triggered_tests on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu_triggered_tests/builds/31412)
6 years, 5 months ago (2014-07-24 06:48:58 UTC) #10
dominicc (has gone to gerrit)
The CQ bit was checked by dominicc@chromium.org
6 years, 5 months ago (2014-07-24 07:00:16 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dominicc@chromium.org/412763002/20001
6 years, 5 months ago (2014-07-24 07:01:20 UTC) #12
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-24 07:01:30 UTC) #13
commit-bot: I haz the power
Failed to apply patch for Source/modules/crypto/SubtleCrypto.cpp: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
6 years, 5 months ago (2014-07-24 07:01:31 UTC) #14
dominicc (has gone to gerrit)
The CQ bit was checked by dominicc@chromium.org
6 years, 5 months ago (2014-07-24 07:33:45 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dominicc@chromium.org/412763002/40001
6 years, 5 months ago (2014-07-24 07:35:12 UTC) #16
commit-bot: I haz the power
6 years, 5 months ago (2014-07-24 08:49:25 UTC) #17
Message was sent while issue was closed.
Change committed as 178827

Powered by Google App Engine
This is Rietveld 408576698