Move apps/shell to extensions/shell.

Move apps/shell to extensions/shell.

This does:
- Move files
- Fix up all namespaces in these files to be extensions, not apps
- Clean up DEPS files

This does not:
- Change the name of the build targets (app_shell, app_shell_browsertests)

BUG=394987
TBR=ben@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=285144

[Yoyo Zhou, 2014-07-22 23:49:12]

jamescook: please review.
oshima: please OWNERS-review for athena.
ben: please OWNERS-review for DEPS changes; the "missing LGTM from OWNERS of
dependencies added to DEPS" presubmit complains about everything in
extensions/shell because they look like new DEPS files, even though they're
mostly just moved.

https://chromiumcodereview.appspot.com/412713002/diff/1/extensions/shell/brow...
File extensions/shell/browser/shell_content_browser_client.cc (right):

https://chromiumcodereview.appspot.com/412713002/diff/1/extensions/shell/brow...
extensions/shell/browser/shell_content_browser_client.cc:104: url::kBlobScheme, 
       content::kChromeDevToolsScheme,
clang-format went to town here

[tfarina, 2014-07-22 23:54:20]

https://chromiumcodereview.appspot.com/412713002/diff/40001/athena/main/athen...
File athena/main/athena_app_window_controller.h (right):

https://chromiumcodereview.appspot.com/412713002/diff/40001/athena/main/athen...
athena/main/athena_app_window_controller.h:15: class AthenaAppWindowController :
public apps::ShellAppWindowController {
this won't compile, it is in extensions namespace now.

[James Cook, 2014-07-23 00:16:07]

I like it! Mostly nits, one possible bug due to a renamed function possibly
calling itself.

https://chromiumcodereview.appspot.com/412713002/diff/40001/athena/main/athen...
File athena/main/athena_app_window_controller.cc (right):

https://chromiumcodereview.appspot.com/412713002/diff/40001/athena/main/athen...
athena/main/athena_app_window_controller.cc:23: apps::ShellAppWindow* app_window
= new apps::ShellAppWindow();
like here

https://chromiumcodereview.appspot.com/412713002/diff/40001/athena/main/athen...
File athena/main/athena_app_window_controller.h (right):

https://chromiumcodereview.appspot.com/412713002/diff/40001/athena/main/athen...
athena/main/athena_app_window_controller.h:20: // Overridden from
apps::ShellAppWindowController:
yeah, more namespace stuff here and in the .cc file

https://chromiumcodereview.appspot.com/412713002/diff/40001/athena/resources/...
File athena/resources/athena_resources.gyp (right):

https://chromiumcodereview.appspot.com/412713002/diff/40001/athena/resources/...
athena/resources/athena_resources.gyp:14:
'../../extensions/shell/app_shell.gyp:app_shell_pak',
alphabetize?

https://chromiumcodereview.appspot.com/412713002/diff/40001/extensions/shell/...
File extensions/shell/browser/default_shell_browser_main_delegate.cc (right):

https://chromiumcodereview.appspot.com/412713002/diff/40001/extensions/shell/...
extensions/shell/browser/default_shell_browser_main_delegate.cc:31:
ShellExtensionSystem* extension_system = static_cast<ShellExtensionSystem*>(
So nice to see all the namespaces lining up!

https://chromiumcodereview.appspot.com/412713002/diff/40001/extensions/shell/...
File extensions/shell/browser/default_shell_browser_main_delegate.h (right):

https://chromiumcodereview.appspot.com/412713002/diff/40001/extensions/shell/...
extensions/shell/browser/default_shell_browser_main_delegate.h:8: #include
"extensions/shell/browser/shell_browser_main_delegate.h"
alphabetize

https://chromiumcodereview.appspot.com/412713002/diff/40001/extensions/shell/...
File extensions/shell/browser/shell_browser_main_parts.cc (right):

https://chromiumcodereview.appspot.com/412713002/diff/40001/extensions/shell/...
extensions/shell/browser/shell_browser_main_parts.cc:41:
EnsureBrowserContextKeyedServiceFactoriesBuilt();
Doesn't this just call itself?  It might need to be the original version, or
better yet rename one of the functions.

https://chromiumcodereview.appspot.com/412713002/diff/40001/extensions/shell/...
File extensions/shell/browser/shell_content_browser_client.cc (right):

https://chromiumcodereview.appspot.com/412713002/diff/40001/extensions/shell/...
extensions/shell/browser/shell_content_browser_client.cc:104: url::kBlobScheme, 
       content::kChromeDevToolsScheme,
clang format might like this, but I prefer the original version

https://chromiumcodereview.appspot.com/412713002/diff/40001/extensions/shell/...
File extensions/shell/browser/shell_omaha_query_params_delegate.cc (right):

https://chromiumcodereview.appspot.com/412713002/diff/40001/extensions/shell/...
extensions/shell/browser/shell_omaha_query_params_delegate.cc:19: return
"&prodversion=38.1234.5678.9";
Aside, I wonder if this will cause problems when Chrome 38 or 39 ships

https://chromiumcodereview.appspot.com/412713002/diff/40001/extensions/shell/...
File extensions/shell/common/shell_extensions_client.h (right):

https://chromiumcodereview.appspot.com/412713002/diff/40001/extensions/shell/...
extensions/shell/common/shell_extensions_client.h:16: class
ShellExtensionsClient : public ExtensionsClient {
Did this get the wrong original source file for the rename? Experiment with
--similarity maybe?

[Yoyo Zhou, 2014-07-23 00:59:50]

https://chromiumcodereview.appspot.com/412713002/diff/40001/athena/main/athen...
File athena/main/athena_app_window_controller.cc (right):

https://chromiumcodereview.appspot.com/412713002/diff/40001/athena/main/athen...
athena/main/athena_app_window_controller.cc:23: apps::ShellAppWindow* app_window
= new apps::ShellAppWindow();
On 2014/07/23 00:16:06, James Cook wrote:
> like here

Fixed.

https://chromiumcodereview.appspot.com/412713002/diff/40001/athena/main/athen...
File athena/main/athena_app_window_controller.h (right):

https://chromiumcodereview.appspot.com/412713002/diff/40001/athena/main/athen...
athena/main/athena_app_window_controller.h:15: class AthenaAppWindowController :
public apps::ShellAppWindowController {
On 2014/07/22 23:54:20, tfarina wrote:
> this won't compile, it is in extensions namespace now.

Done.

https://chromiumcodereview.appspot.com/412713002/diff/40001/athena/main/athen...
athena/main/athena_app_window_controller.h:20: // Overridden from
apps::ShellAppWindowController:
On 2014/07/23 00:16:06, James Cook wrote:
> yeah, more namespace stuff here and in the .cc file

Done.

https://chromiumcodereview.appspot.com/412713002/diff/40001/athena/resources/...
File athena/resources/athena_resources.gyp (right):

https://chromiumcodereview.appspot.com/412713002/diff/40001/athena/resources/...
athena/resources/athena_resources.gyp:14:
'../../extensions/shell/app_shell.gyp:app_shell_pak',
On 2014/07/23 00:16:06, James Cook wrote:
> alphabetize?

Done.

https://chromiumcodereview.appspot.com/412713002/diff/40001/extensions/shell/...
File extensions/shell/browser/default_shell_browser_main_delegate.h (right):

https://chromiumcodereview.appspot.com/412713002/diff/40001/extensions/shell/...
extensions/shell/browser/default_shell_browser_main_delegate.h:8: #include
"extensions/shell/browser/shell_browser_main_delegate.h"
On 2014/07/23 00:16:07, James Cook wrote:
> alphabetize

Done.

https://chromiumcodereview.appspot.com/412713002/diff/40001/extensions/shell/...
File extensions/shell/browser/shell_browser_main_parts.cc (right):

https://chromiumcodereview.appspot.com/412713002/diff/40001/extensions/shell/...
extensions/shell/browser/shell_browser_main_parts.cc:41:
EnsureBrowserContextKeyedServiceFactoriesBuilt();
On 2014/07/23 00:16:07, James Cook wrote:
> Doesn't this just call itself?  It might need to be the original version, or
> better yet rename one of the functions.

Oops, this was a mistake. It should be the original. Good catch!

https://chromiumcodereview.appspot.com/412713002/diff/40001/extensions/shell/...
File extensions/shell/browser/shell_content_browser_client.cc (right):

https://chromiumcodereview.appspot.com/412713002/diff/40001/extensions/shell/...
extensions/shell/browser/shell_content_browser_client.cc:104: url::kBlobScheme, 
       content::kChromeDevToolsScheme,
On 2014/07/23 00:16:07, James Cook wrote:
> clang format might like this, but I prefer the original version

Ditto.

https://chromiumcodereview.appspot.com/412713002/diff/40001/extensions/shell/...
File extensions/shell/browser/shell_omaha_query_params_delegate.cc (right):

https://chromiumcodereview.appspot.com/412713002/diff/40001/extensions/shell/...
extensions/shell/browser/shell_omaha_query_params_delegate.cc:19: return
"&prodversion=38.1234.5678.9";
On 2014/07/23 00:16:07, James Cook wrote:
> Aside, I wonder if this will cause problems when Chrome 38 or 39 ships

content_shell uses version 19.77.34.5 (content/content_shell.gypi). I picked 38
because it was the current trunk at the time.

https://chromiumcodereview.appspot.com/412713002/diff/40001/extensions/shell/...
File extensions/shell/common/shell_extensions_client.h (right):

https://chromiumcodereview.appspot.com/412713002/diff/40001/extensions/shell/...
extensions/shell/common/shell_extensions_client.h:16: class
ShellExtensionsClient : public ExtensionsClient {
On 2014/07/23 00:16:07, James Cook wrote:
> Did this get the wrong original source file for the rename? Experiment with
> --similarity maybe?

This happened for a few files, but I don't think it will get the correct source
file; at best it will treat it as a brand new file.

Anyway, it looks like increasing the threshold has turned it into an add rather
than a copy.

[oshima, 2014-07-23 06:49:21]

athena/ lgtm

[James Cook, 2014-07-23 16:22:26]

LGTM but please reupload with the original similarity to maximize the number of
files that are picked up as rename instead of add.  Otherwise I think we lose
history in svn.

[Yoyo Zhou, 2014-07-23 20:18:03]

Uploaded again at --similarity=40.

Changing ben@ to TBR, since on close inspection, there are not actually any new
DEPS being added.

[Yoyo Zhou, 2014-07-23 20:18:11]

The CQ bit was checked by yoz@chromium.org

[commit-bot: I haz the power, 2014-07-23 20:20:24]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/yoz@chromium.org/412713002/100001

[commit-bot: I haz the power, 2014-07-24 03:39:40]

Change committed as 285144