Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Issue 412703002: Modify DEPS to recurse into third_party/WebKit (Blink) as well. (Closed)

Created:
6 years, 5 months ago by Dirk Pranke
Modified:
6 years, 5 months ago
Reviewers:
eseidel
CC:
chromium-reviews, darin-cc_chromium.org
Project:
chromium
Visibility:
Public.

Description

Modify DEPS to recurse into third_party/WebKit (Blink) as well. This will allow us to control the versions of the w3c test repos we depend on through a file in Blink rather than a file in Chromium; this makes sense since the tests affect Blink, and it makes it far easier for us to roll in new versions of the w3c repos. We also merge in the existing test failures from Blink's TestExpectations files; as part of this change we are moving the test repos from LayoutTests/w3c to LayoutTests/third_party, and in order to do this move we need to move the failures for the old location from a blink-controlled file to a chromium-controlled file. This is patch 2 of 4 in the process to move things. This patch depends on https://codereview.chromium.org/410803002 . R=eseidel@chromium.org BUG=395862 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=285146

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+51 lines, -0 lines) Patch
M DEPS View 1 chunk +4 lines, -0 lines 0 comments Download
M webkit/tools/layout_tests/test_expectations_w3c.txt View 1 chunk +47 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Dirk Pranke
6 years, 5 months ago (2014-07-22 23:23:01 UTC) #1
eseidel
lgtm
6 years, 5 months ago (2014-07-22 23:42:06 UTC) #2
Dirk Pranke
The CQ bit was checked by dpranke@chromium.org
6 years, 5 months ago (2014-07-23 19:50:38 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dpranke@chromium.org/412703002/1
6 years, 5 months ago (2014-07-23 19:53:20 UTC) #4
commit-bot: I haz the power
6 years, 5 months ago (2014-07-24 03:46:52 UTC) #5
Message was sent while issue was closed.
Change committed as 285146

Powered by Google App Engine
This is Rietveld 408576698