Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(58)

Unified Diff: media/formats/mp4/box_definitions.cc

Issue 412693002: Don't check reserved bits when parsing AVCDecoderConfigurationRecords. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/formats/mp4/box_definitions.cc
diff --git a/media/formats/mp4/box_definitions.cc b/media/formats/mp4/box_definitions.cc
index 8bf4ca52d120477e07521507cd8cd293b678d7a5..b3060ebe9ffc82bacf73729d0f02a736bb2ae4ba 100644
--- a/media/formats/mp4/box_definitions.cc
+++ b/media/formats/mp4/box_definitions.cc
@@ -379,14 +379,13 @@ bool AVCDecoderConfigurationRecord::ParseInternal(BufferReader* reader,
reader->Read1(&avc_level));
uint8 length_size_minus_one;
- RCHECK(reader->Read1(&length_size_minus_one) &&
- (length_size_minus_one & 0xfc) == 0xfc);
+ RCHECK(reader->Read1(&length_size_minus_one));
length_size = (length_size_minus_one & 0x3) + 1;
RCHECK(length_size != 3); // Only values of 1, 2, and 4 are valid.
uint8 num_sps;
- RCHECK(reader->Read1(&num_sps) && (num_sps & 0xe0) == 0xe0);
+ RCHECK(reader->Read1(&num_sps));
num_sps &= 0x1f;
sps_list.resize(num_sps);
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698