Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(126)

Issue 412533002: Remove unnecessary includes from collection / nodelist classes (Closed)

Created:
6 years, 5 months ago by Inactive
Modified:
6 years, 5 months ago
Reviewers:
adamk
CC:
blink-reviews, blink-reviews-dom_chromium.org, blink-reviews-html_chromium.org, dglazkov+blink, eae+blinkwatch, rwlbuis, sof
Project:
blink
Visibility:
Public.

Description

Remove unnecessary includes from collection / nodelist classes Remove unnecessary includes from collection / nodelist classes to reduce interdependency and make build time shorter in case of change. R=adamk@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=178690

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -6 lines) Patch
M Source/core/dom/ChildNodeList.h View 1 chunk +1 line, -0 lines 1 comment Download
M Source/core/dom/LiveNodeListBase.h View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/html/CollectionIndexCache.h View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/html/HTMLCollection.h View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 15 (0 generated)
Inactive
https://codereview.chromium.org/412533002/diff/1/Source/core/dom/ChildNodeList.h File Source/core/dom/ChildNodeList.h (right): https://codereview.chromium.org/412533002/diff/1/Source/core/dom/ChildNodeList.h#newcode28 Source/core/dom/ChildNodeList.h:28: #include "core/dom/ContainerNode.h" Now needed because I dropped the Element.h ...
6 years, 5 months ago (2014-07-22 16:44:42 UTC) #1
adamk
lgtm
6 years, 5 months ago (2014-07-22 16:55:40 UTC) #2
Inactive
The CQ bit was checked by ch.dumez@samsung.com
6 years, 5 months ago (2014-07-22 16:56:15 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/412533002/1
6 years, 5 months ago (2014-07-22 16:57:26 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_gpu_triggered_tests on tryserver.chromium.gpu ...
6 years, 5 months ago (2014-07-22 17:44:42 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-22 18:23:56 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: win_gpu_triggered_tests on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu_triggered_tests/builds/30917)
6 years, 5 months ago (2014-07-22 18:23:56 UTC) #7
Inactive
The CQ bit was checked by ch.dumez@samsung.com
6 years, 5 months ago (2014-07-22 18:24:39 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/412533002/1
6 years, 5 months ago (2014-07-22 18:25:30 UTC) #9
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_gpu_triggered_tests on tryserver.chromium.gpu ...
6 years, 5 months ago (2014-07-22 19:13:48 UTC) #10
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-22 20:02:43 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: win_gpu_triggered_tests on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu_triggered_tests/builds/30974)
6 years, 5 months ago (2014-07-22 20:02:44 UTC) #12
Inactive
The CQ bit was checked by ch.dumez@samsung.com
6 years, 5 months ago (2014-07-22 20:03:29 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/412533002/1
6 years, 5 months ago (2014-07-22 20:04:20 UTC) #14
commit-bot: I haz the power
6 years, 5 months ago (2014-07-22 20:38:53 UTC) #15
Message was sent while issue was closed.
Change committed as 178690

Powered by Google App Engine
This is Rietveld 408576698