Checking structure sizes before reading them from memory to avoid overflowing the buffer's stream.

include/core/SkMatrix.h

Index: include/core/SkMatrix.h
diff --git a/include/core/SkMatrix.h b/include/core/SkMatrix.h
index b6856d103c57fe45849b51c2d77c5d7449552afa..3350715c375729b0a647abc94366744d22d61218 100644
--- a/include/core/SkMatrix.h
+++ b/include/core/SkMatrix.h
@@ -560,8 +560,14 @@ public:
     };
     // return the number of bytes written, whether or not buffer is null
     uint32_t writeToMemory(void* buffer) const;
-    // return the number of bytes read
-    uint32_t readFromMemory(const void* buffer);
+    /**
+     * Reads data from the buffer parameter
+     *
+     * @param buffer Memory to read from
+     * @param length Amount of memory available in the buffer
+     * @return number of bytes read or 0 if there was not enough memory available
+     */
+    uint32_t readFromMemory(const void* buffer, uint32_t length);

[reed1, 2013/10/29 19:42:58]

size_t ?

[sugoi1, 2013/10/29 20:16:47]

I assume this comment applies to all readFromMemory and writeToMemory functions.
Will do.

 
     SkDEVCODE(void dump() const;)
     SkDEVCODE(void toString(SkString*) const;)