Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(540)

Unified Diff: include/core/SkMatrix.h

Issue 41253002: Checking structure sizes before reading them from memory to avoid overflowing the buffer's stream. (Closed) Base URL: https://skia.googlecode.com/svn/trunk
Patch Set: Removing SkMatrix's writeToMemory, readFromMemory Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | include/core/SkPath.h » ('j') | include/core/SkReader32.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: include/core/SkMatrix.h
diff --git a/include/core/SkMatrix.h b/include/core/SkMatrix.h
index b6856d103c57fe45849b51c2d77c5d7449552afa..f7ca34789a6f224f6bc116099064e902ff241c32 100644
--- a/include/core/SkMatrix.h
+++ b/include/core/SkMatrix.h
@@ -554,15 +554,6 @@ public:
return !(a == b);
}
- enum {
- // writeTo/readFromMemory will never return a value larger than this
- kMaxFlattenSize = 9 * sizeof(SkScalar) + sizeof(uint32_t)
- };
- // return the number of bytes written, whether or not buffer is null
- uint32_t writeToMemory(void* buffer) const;
- // return the number of bytes read
- uint32_t readFromMemory(const void* buffer);
-
SkDEVCODE(void dump() const;)
SkDEVCODE(void toString(SkString*) const;)
« no previous file with comments | « no previous file | include/core/SkPath.h » ('j') | include/core/SkReader32.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698