samplecode/SampleRegion.cpp - Issue 41253002: Checking structure sizes before reading them from memory to avoid overflowing the buffer's stream.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: samplecode/SampleRegion.cpp

Issue 41253002: Checking structure sizes before reading them from memory to avoid overflowing the buffer's stream. (Closed) Base URL: https://skia.googlecode.com/svn/trunk

Patch Set: Adding validation before memory allocation in SkRegion::readFromMemory Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: samplecode/SampleRegion.cpp

diff --git a/samplecode/SampleRegion.cpp b/samplecode/SampleRegion.cpp

index 1bd316233f9fb84941744dac695d85e981ab34ae..39c27a89281060a4c502b5f5d60104447734410f 100644

--- a/samplecode/SampleRegion.cpp

+++ b/samplecode/SampleRegion.cpp

@@ -280,7 +280,7 @@ protected:

SkASSERT(size == size2);

SkRegion tmp3;

- SkDEBUGCODE(size2 = ) tmp3.readFromMemory(buffer);

+ SkDEBUGCODE(size2 = ) tmp3.readFromMemory(buffer, 1000);

SkASSERT(size == size2);

SkASSERT(tmp3 == tmp);

« no previous file with comments | « include/core/SkRegion.h ('k') | src/core/SkBuffer.h » ('j') | tests/SerializationTest.cpp » ('J')