include/core/SkMatrix.h - Issue 41253002: Checking structure sizes before reading them from memory to avoid overflowing the buffer's stream.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: include/core/SkMatrix.h

Issue 41253002: Checking structure sizes before reading them from memory to avoid overflowing the buffer's stream. (Closed) Base URL: https://skia.googlecode.com/svn/trunk

Patch Set: Adding length info to read operations Created 7 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: include/core/SkMatrix.h

diff --git a/include/core/SkMatrix.h b/include/core/SkMatrix.h

index b6856d103c57fe45849b51c2d77c5d7449552afa..4cefa30f2806fb56e2fa1a1abf71e9a72d5100f2 100644

--- a/include/core/SkMatrix.h

+++ b/include/core/SkMatrix.h

@@ -561,7 +561,7 @@ public:

// return the number of bytes written, whether or not buffer is null

uint32_t writeToMemory(void* buffer) const;

// return the number of bytes read

reed1 2013/10/25 14:42:46 // Please document what 'length' is used for.

sugoi1 2013/10/25 14:59:02 Done.

- uint32_t readFromMemory(const void* buffer);

+ uint32_t readFromMemory(const void* buffer, uint32_t length);

SkDEVCODE(void dump() const;)

SkDEVCODE(void toString(SkString*) const;)

« no previous file with comments | « no previous file | include/core/SkPath.h » ('j') | no next file with comments »