Checking structure sizes before reading them from memory to avoid overflowing the buffer's stream.

include/core/SkPath.h

 
 /*
  * Copyright 2006 The Android Open Source Project
  *
  * Use of this source code is governed by a BSD-style license that can be
  * found in the LICENSE file.
  */
 
 
 #ifndef SkPath_DEFINED
 #define SkPath_DEFINED
 
 #include "SkInstCnt.h"
 #include "SkMatrix.h"
 #include "SkPathRef.h"
 #include "SkTDArray.h"
 #include "SkRefCnt.h"
 
 #ifdef SK_BUILD_FOR_ANDROID
 #define GEN_ID_INC              fGenerationID++
 #define GEN_ID_PTR_INC(ptr)     (ptr)->fGenerationID++
 #else
 #define GEN_ID_INC
 #define GEN_ID_PTR_INC(ptr)
 #endif
 
 class SkReader32;
 class SkWriter32;
 class SkAutoPathBoundsUpdate;
+class SkFlattenableReadBuffer;
 class SkString;
 class SkRRect;
 
 /** \class SkPath
 
     The SkPath class encapsulates compound (multiple contour) geometric paths
     consisting of straight line segments, quadratic curves, and cubic curves.
 */
 class SK_API SkPath {
 public:
@@ skipping 863 matching lines @@
     /**
      *  Returns true if the point { x, y } is contained by the path, taking into
      *  account the FillType.
      */
     bool contains(SkScalar x, SkScalar y) const;
 
     void dump(bool forceClose, const char title[] = NULL) const;
     void dump() const;
 
     /**
+     *  Returns the number of bytes of the current object's flattened representation.
+     */
+    uint32_t sizeInMemory() const;
+    /**
+     *  Returns the number of bytes to read.
+     */
+    static uint32_t SizeToRead(SkFlattenableReadBuffer& buffer);

[reed1, 2013/10/24 20:51:19]

:( Do we really need to teach SkPath about readbuffers? What is wrong with the
current memory-based interface?

+    /**
      *  Write the region to the buffer, and return the number of bytes written.
      *  If buffer is NULL, it still returns the number of bytes.
      */
     uint32_t writeToMemory(void* buffer) const;
     /**
      *  Initialized the region from the buffer, returning the number
      *  of bytes actually read.
      */
     uint32_t readFromMemory(const void* buffer);
 
@@ skipping 93 matching lines @@
 #ifndef DELETE_THIS_CODE_WHEN_SKPS_ARE_REBUILT_AT_V14_AND_ALL_OTHER_INSTANCES_TOO
     friend class SkPathRef;     // just for SerializationOffsets
 #endif
     friend class SkAutoPathBoundsUpdate;
     friend class SkAutoDisableOvalCheck;
     friend class SkAutoDisableDirectionCheck;
     friend class SkBench_AddPathTest; // perf test pathTo/reversePathTo
 };
 
 #endif